Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2277663002: Remove WTF::isShutdown() (Closed)

Created:
4 years, 4 months ago by haraken
Modified:
4 years, 4 months ago
Reviewers:
Yuta Kitamura
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WTF::isShutdown() Now it's unused. BUG=639244 Committed: https://crrev.com/47f9c2d1ca781e1e4df5dc05b74200a6ba696afe Cr-Commit-Position: refs/heads/master@{#414030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M third_party/WebKit/Source/wtf/WTF.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/WTF.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
haraken
PTAL
4 years, 4 months ago (2016-08-24 05:42:20 UTC) #4
Yuta Kitamura
lgtm
4 years, 4 months ago (2016-08-24 08:18:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277663002/1
4 years, 4 months ago (2016-08-24 09:27:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 09:32:58 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/47f9c2d1ca781e1e4df5dc05b74200a6ba696afe Cr-Commit-Position: refs/heads/master@{#414030}
4 years, 4 months ago (2016-08-24 09:34:51 UTC) #12
haraken
4 years, 3 months ago (2016-09-05 00:30:11 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2311713002/ by haraken@chromium.org.

The reason for reverting is: I'll revert r413430 and its dependent CLs because
r413430 caused issue 642072.

The problem is that we cannot simply remove blink::shutdown because the
following scenario can happen:

1) blink::shutdown is not called. Workers are still running.
2) RenderThreadImpl gets destructed. MessageLoop gets destructed.
3) The workers may access the RenderThreadImpl and MessageLoop.

To fix the problem, we need to call ProcessDied() and forcibly kill the renderer
process at the end of RenderThreadImpl::Shutdown().
.

Powered by Google App Engine
This is Rietveld 408576698