Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: net/cert/sct_status_flags.h

Issue 2277653002: Bring back SCT_STATUS_INVALID for cached entries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix SCT_STATUS_INVALID comment to not refer to disk cache Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/ct_sct_to_string.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/sct_status_flags.h
diff --git a/net/cert/sct_status_flags.h b/net/cert/sct_status_flags.h
index ac0bc7d7e6716793c9911833fc089eff881818a9..cdd63b9ffb2181e1fa1b60f43aa53769513a3e2e 100644
--- a/net/cert/sct_status_flags.h
+++ b/net/cert/sct_status_flags.h
@@ -21,9 +21,12 @@ enum SCTVerifyStatus {
// The SCT is from an unknown log, so we cannot verify its signature.
SCT_STATUS_LOG_UNKNOWN = 1,
- // SCTVerifyStatus=2 used to represent SCT_STATUS_INVALID, which has now been
- // split into INVALID_SIGNATURE and INVALID_TIMESTAMP to represent the
- // different reasons an SCT could be invalid.
+ // This value is deprecated and should not be used. It has been split
+ // into INVALID_SIGNATURE and INVALID_TIMESTAMP to represent the
+ // different reasons an SCT could be invalid. Though it is no longer
+ // in use, it is preserved here because it may be present in
+ // serialized messages.
+ SCT_STATUS_INVALID = 2,
// The SCT is from a known log, and the signature is valid.
SCT_STATUS_OK = 3,
« no previous file with comments | « net/cert/ct_sct_to_string.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698