Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: net/quic/chromium/quic_chromium_client_session.cc

Issue 2277633006: Removes unused code in QuicStreamFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/chromium/quic_stream_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_chromium_client_session.cc
diff --git a/net/quic/chromium/quic_chromium_client_session.cc b/net/quic/chromium/quic_chromium_client_session.cc
index 15aee3e7d61d9f49ac27a4804a68b1e1a4cd3bb5..02271b123aac9ba1ef6dee278eef693f6c14b37b 100644
--- a/net/quic/chromium/quic_chromium_client_session.cc
+++ b/net/quic/chromium/quic_chromium_client_session.cc
@@ -1171,15 +1171,8 @@ void QuicChromiumClientSession::NotifyFactoryOfSessionClosed() {
void QuicChromiumClientSession::OnConnectTimeout() {
Ryan Hamilton 2016/08/25 21:50:54 Since this code does nothing shall we remove it to
Jana 2016/08/25 22:03:44 Good idea, and seems fine to remove -- Done.
DCHECK(callback_.is_null());
-
if (IsCryptoHandshakeConfirmed())
return;
-
- // TODO(rch): re-enable this code once beta is cut.
- // if (stream_factory_)
- // stream_factory_->OnSessionConnectTimeout(this);
- // CloseAllStreams(ERR_QUIC_HANDSHAKE_FAILED);
- // DCHECK_EQ(0u, GetNumOpenOutgoingStreams());
}
bool QuicChromiumClientSession::MigrateToSocket(
« no previous file with comments | « no previous file | net/quic/chromium/quic_stream_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698