Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2277633006: Removes unused code in QuicStreamFactory. (Closed)

Created:
4 years, 3 months ago by Jana
Modified:
4 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes unused code in QuicStreamFactory. R=rch@chromium.org BUG= Committed: https://crrev.com/de9f86b5bcd9b4ef4415d860c3711403a9a69be6 Cr-Commit-Position: refs/heads/master@{#414601}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed OnConnectTimeout. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -58 lines) Patch
M net/quic/chromium/quic_chromium_client_session.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 1 3 chunks +1 line, -25 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Jana
4 years, 3 months ago (2016-08-25 21:46:01 UTC) #1
Ryan Hamilton
lgtm, but one more method to remove, I think https://codereview.chromium.org/2277633006/diff/1/net/quic/chromium/quic_chromium_client_session.cc File net/quic/chromium/quic_chromium_client_session.cc (right): https://codereview.chromium.org/2277633006/diff/1/net/quic/chromium/quic_chromium_client_session.cc#newcode1172 net/quic/chromium/quic_chromium_client_session.cc:1172: ...
4 years, 3 months ago (2016-08-25 21:50:54 UTC) #2
Jana
Thanks, Ryan https://codereview.chromium.org/2277633006/diff/1/net/quic/chromium/quic_chromium_client_session.cc File net/quic/chromium/quic_chromium_client_session.cc (right): https://codereview.chromium.org/2277633006/diff/1/net/quic/chromium/quic_chromium_client_session.cc#newcode1172 net/quic/chromium/quic_chromium_client_session.cc:1172: void QuicChromiumClientSession::OnConnectTimeout() { On 2016/08/25 21:50:54, Ryan ...
4 years, 3 months ago (2016-08-25 22:03:45 UTC) #3
Ryan Hamilton
lgtm
4 years, 3 months ago (2016-08-25 22:07:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277633006/20001
4 years, 3 months ago (2016-08-25 22:08:07 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 00:37:37 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 00:38:58 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/de9f86b5bcd9b4ef4415d860c3711403a9a69be6
Cr-Commit-Position: refs/heads/master@{#414601}

Powered by Google App Engine
This is Rietveld 408576698