Implement tex{Sub}Image{2|3}D with ArrayBufferView sub source.

third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/webgl/WebGL2RenderingContextBase.h"
 
 #include "bindings/modules/v8/WebGLAny.h"
 #include "core/frame/ImageBitmap.h"
 #include "core/html/HTMLCanvasElement.h"
 #include "core/html/HTMLImageElement.h"
@@ skipping 23 matching lines @@
 
 namespace blink {
 
 namespace {
 
 GLsync syncObjectOrZero(const WebGLSync* object)
 {
     return object ? object->object() : nullptr;
 }
 
-size_t getViewTypeSize(WTF::ArrayBufferView::ViewType viewType)
-{
-    switch (viewType) {
-    case WTF::ArrayBufferView::TypeInt8:
-    case WTF::ArrayBufferView::TypeUint8:
-    case WTF::ArrayBufferView::TypeUint8Clamped:
-        return 1;
-    case WTF::ArrayBufferView::TypeInt16:
-    case WTF::ArrayBufferView::TypeUint16:
-        return 2;
-    case WTF::ArrayBufferView::TypeInt32:
-    case WTF::ArrayBufferView::TypeUint32:
-    case WTF::ArrayBufferView::TypeFloat32:
-        return 4;
-    case WTF::ArrayBufferView::TypeFloat64:
-        return 8;
-    case WTF::ArrayBufferView::TypeDataView:
-        return 1;
-    default:
-        NOTREACHED();
-        return 0;
-    }
-}
-
 bool validateSubSourceAndGetData(DOMArrayBufferView* view, GLuint subOffset, GLuint subLength, void** outBaseAddress, long long* outByteLength)
 {
     // This is guaranteed to be non-null by DOM.
     DCHECK(view);
 
-    size_t typeSize = getViewTypeSize(view->type());
+    size_t typeSize = view->typeSize();
     DCHECK_GE(8u, typeSize);
     long long byteLength = 0;
     if (subLength) {
         // type size is at most 8, so no overflow.
         byteLength = subLength * typeSize;
     }
     long long byteOffset = 0;
     if (subOffset) {
         // type size is at most 8, so no overflow.
         byteOffset = subOffset * typeSize;
@@ skipping 902 matching lines @@
 
 void WebGL2RenderingContextBase::texImage2D(GLenum target, GLint level, GLint internalformat, GLsizei width, GLsizei height,
     GLint border, GLenum format, GLenum type, DOMArrayBufferView* data)
 {
     WebGLRenderingContextBase::texImage2D(target, level, internalformat, width, height, border, format, type, data);
 }
 
 void WebGL2RenderingContextBase::texImage2D(GLenum target, GLint level, GLint internalformat, GLsizei width, GLsizei height,
     GLint border, GLenum format, GLenum type, DOMArrayBufferView* data, GLuint srcOffset)
 {
-    // TODO(zmo): To be implemented.
+    texImageHelperDOMArrayBufferView(TexImage2D, target, level, internalformat, width, height, 1, border,
+        format, type, 0, 0, 0, data, NullNotReachable, srcOffset);
 }
 
 void WebGL2RenderingContextBase::texImage2D(GLenum target, GLint level, GLint internalformat, GLsizei width, GLsizei height,
     GLint border, GLenum format, GLenum type, ImageData* imageData)
 {
     // TODO(zmo): To be implemented.
 }
 
 void WebGL2RenderingContextBase::texImage2D(GLenum target, GLint level, GLint internalformat, GLsizei width, GLsizei height,
     GLint border, GLenum format, GLenum type, HTMLImageElement* image, ExceptionState& exceptionState)
@@ skipping 46 matching lines @@
 
 void WebGL2RenderingContextBase::texSubImage2D(GLenum target, GLint level, GLint xoffset, GLint yoffset,
     GLsizei width, GLsizei height, GLenum format, GLenum type, DOMArrayBufferView* pixels)
 {
     WebGLRenderingContextBase::texSubImage2D(target, level, xoffset, yoffset, width, height, format, type, pixels);
 }
 
 void WebGL2RenderingContextBase::texSubImage2D(GLenum target, GLint level, GLint xoffset, GLint yoffset,
     GLsizei width, GLsizei height, GLenum format, GLenum type, DOMArrayBufferView* pixels, GLuint srcOffset)
 {
-    // TODO(zmo): To be implemented.
+    texImageHelperDOMArrayBufferView(TexSubImage2D, target, level, 0, width, height, 1, 0, format, type,
+        xoffset, yoffset, 0, pixels, NullNotReachable, srcOffset);
 }
 
 void WebGL2RenderingContextBase::texSubImage2D(GLenum target, GLint level, GLint xoffset, GLint yoffset,
     GLsizei width, GLsizei height, GLenum format, GLenum type, ImageData* pixels)
 {
     // TODO(zmo): To be implemented.
 }
 
 void WebGL2RenderingContextBase::texSubImage2D(GLenum target, GLint level, GLint xoffset, GLint yoffset,
     GLsizei width, GLsizei height, GLenum format, GLenum type, HTMLImageElement* image, ExceptionState& exceptionState)
@@ skipping 61 matching lines @@
 {
     if (isContextLost() || !validateTexStorage("texStorage3D", target, levels, internalformat, width, height, depth, TexStorageType3D))
         return;
 
     contextGL()->TexStorage3D(target, levels, internalformat, width, height, depth);
 }
 
 void WebGL2RenderingContextBase::texImage3D(GLenum target, GLint level, GLint internalformat, GLsizei width, GLsizei height, GLsizei depth,
     GLint border, GLenum format, GLenum type, DOMArrayBufferView* pixels)
 {
-    texImageHelperDOMArrayBufferView(TexImage3D, target, level, internalformat, width, height, border, format, type, depth, 0, 0, 0, pixels);
+    texImageHelperDOMArrayBufferView(TexImage3D, target, level, internalformat, width, height, depth, border,
+        format, type, 0, 0, 0, pixels, NullAllowed, 0);
 }
 
 void WebGL2RenderingContextBase::texImage3D(GLenum target, GLint level, GLint internalformat, GLsizei width, GLsizei height, GLsizei depth,
     GLint border, GLenum format, GLenum type, DOMArrayBufferView* pixels, GLuint srcOffset)
 {
-    // TODO(zmo): To be implemented.
+    texImageHelperDOMArrayBufferView(TexImage3D, target, level, internalformat, width, height, depth, border,
+        format, type, 0, 0, 0, pixels, NullNotReachable, srcOffset);
 }
 
 void WebGL2RenderingContextBase::texImage3D(GLenum target, GLint level, GLint internalformat, GLsizei width, GLsizei height, GLsizei depth,
     GLint border, GLenum format, GLenum type, GLintptr offset)
 {
     if (isContextLost())
         return;
     if (!validateTexture3DBinding("texImage3D", target))
         return;
     if (!m_boundPixelUnpackBuffer) {
@@ skipping 34 matching lines @@
 
 void WebGL2RenderingContextBase::texImage3D(GLenum target, GLint level, GLint internalformat, GLsizei width, GLsizei height, GLsizei depth,
     GLint border, GLenum format, GLenum type, ImageBitmap* imageBitMap, ExceptionState& exceptionState)
 {
     // TODO(zmo): To be implemented.
 }
 
 void WebGL2RenderingContextBase::texSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset, GLint zoffset, GLsizei width, GLsizei height, GLsizei depth,
     GLenum format, GLenum type, DOMArrayBufferView* pixels, GLuint srcOffset)
 {
-    // TODO(zmo): To be implemented.
-    texImageHelperDOMArrayBufferView(TexSubImage3D, target, level, 0, width, height, 0, format, type, depth, xoffset, yoffset, zoffset, pixels);
+    texImageHelperDOMArrayBufferView(TexSubImage3D, target, level, 0, width, height, depth, 0, format, type,
+        xoffset, yoffset, zoffset, pixels, NullNotReachable, srcOffset);
 }
 
 void WebGL2RenderingContextBase::texSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset, GLint zoffset, GLsizei width, GLsizei height, GLsizei depth,
     GLenum format, GLenum type, GLintptr offset)
 {
     if (isContextLost())
         return;
     if (!validateTexture3DBinding("texSubImage3D", target))
         return;
     if (!m_boundPixelUnpackBuffer) {
@@ skipping 2422 matching lines @@
     params.skipPixels = m_unpackSkipPixels;
     params.skipRows = m_unpackSkipRows;
     if (dimension == Tex3D) {
         params.imageHeight = m_unpackImageHeight;
         params.skipImages = m_unpackSkipImages;
     }
     return params;
 }
 
 } // namespace blink