Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java

Issue 2277603002: Extract tabbed mode specific logic from the TabPersistenceStore. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix findbugs Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
index 3e02c50728f4091fa700254e9867e7855417de39..9c45b4bcb8e25002646619188b7b7532c28e23a1 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
@@ -19,8 +19,6 @@ import android.util.DisplayMetrics;
import android.util.Log;
import android.view.View;
-import junit.framework.Assert;
-
import org.chromium.base.ThreadUtils;
import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.base.test.util.CommandLineFlags;
@@ -51,7 +49,7 @@ import org.chromium.chrome.browser.tabmodel.TabModelObserver;
import org.chromium.chrome.browser.tabmodel.TabModelSelector;
import org.chromium.chrome.browser.tabmodel.TabModelSelectorImpl;
import org.chromium.chrome.browser.tabmodel.TabModelUtils;
-import org.chromium.chrome.browser.tabmodel.TabPersistentStore;
+import org.chromium.chrome.browser.tabmodel.TabbedModeTabPersistencePolicy;
import org.chromium.chrome.browser.toolbar.ToolbarPhone;
import org.chromium.chrome.test.ChromeTabbedActivityTestBase;
import org.chromium.chrome.test.util.ApplicationTestUtils;
@@ -1380,7 +1378,7 @@ public class TabsTest extends ChromeTabbedActivityTestBase {
try {
selectCallback.waitForCallback(0);
} catch (TimeoutException e) {
- Assert.fail("Tab selected event was never received");
+ fail("Tab selected event was never received");
}
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@Override
@@ -1658,7 +1656,7 @@ public class TabsTest extends ChromeTabbedActivityTestBase {
public void testIncognitoTabsNotRestoredAfterSwipe() throws Exception {
newIncognitoTabFromMenu();
- File tabStateDir = TabPersistentStore.getOrCreateStateDirectory();
+ File tabStateDir = TabbedModeTabPersistencePolicy.getOrCreateTabbedModeStateDirectory();
TabModel normalModel = getActivity().getTabModelSelector().getModel(false);
TabModel incognitoModel = getActivity().getTabModelSelector().getModel(true);
File normalTabFile = new File(tabStateDir,

Powered by Google App Engine
This is Rietveld 408576698