chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java - Issue 2277603002: Extract tabbed mode specific logic from the TabPersistenceStore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java

Issue 2277603002: Extract tabbed mode specific logic from the TabPersistenceStore. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix findbugs Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java b/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java

index 77af31f34158f9e7135f25ae7307f9779b503011..da44d60b447388155e811df6b110bd593331dc37 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java

@@ -27,8 +27,8 @@ import org.chromium.chrome.browser.ChromeTabbedActivity;

import org.chromium.chrome.browser.TabState;

import org.chromium.chrome.browser.document.ChromeLauncherActivity;

import org.chromium.chrome.browser.document.DocumentUtils;

-import org.chromium.chrome.browser.tabmodel.TabPersistentStore;

import org.chromium.chrome.browser.tabmodel.TabWindowManager;

+import org.chromium.chrome.browser.tabmodel.TabbedModeTabPersistencePolicy;

import java.io.File;

import java.lang.ref.WeakReference;

@@ -63,7 +63,7 @@ public class IncognitoNotificationService extends IntentService {

closeIncognitoTabsInRunningTabbedActivities();

boolean clearedIncognito = deleteIncognitoStateFilesInDirectory(

- TabPersistentStore.getOrCreateStateDirectory());

+ TabbedModeTabPersistencePolicy.getOrCreateTabbedModeStateDirectory());

// If we failed clearing all of the incognito tabs, then do not dismiss the notification.

if (!clearedIncognito) return;