chrome/browser/ui/views/frame/browser_frame_mus.cc - Issue 2277563002: Wires up immersive mode for chrome and mash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_frame_mus.cc

Issue 2277563002: Wires up immersive mode for chrome and mash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_frame_mus.cc

diff --git a/chrome/browser/ui/views/frame/browser_frame_mus.cc b/chrome/browser/ui/views/frame/browser_frame_mus.cc

index 8e4208eeb6d3a2c92540b1331068e69d8cf24675..b0168eae19ab098d8eed887c7ab57e351030cc56 100644

--- a/chrome/browser/ui/views/frame/browser_frame_mus.cc

+++ b/chrome/browser/ui/views/frame/browser_frame_mus.cc

@@ -29,6 +29,9 @@ ui::Window* CreateMusWindow(BrowserView* browser_view) {

views::NativeWidgetMus::ConfigurePropertiesForNewWindow(

GetWidgetParamsImpl(browser_view), &properties);

const std::string chrome_app_id(extension_misc::kChromeAppId);

+ // Indicates mash shouldn't handle immersive, rather we will.

+ properties[ui::mojom::WindowManager::kDisableImmersive_Property] =

+ mojo::ConvertTo<std::vector<uint8_t>>(true);

properties[ui::mojom::WindowManager::kAppID_Property] =

mojo::ConvertTo<std::vector<uint8_t>>(chrome_app_id);

return views::WindowManagerConnection::Get()->NewWindow(properties);