Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ash/common/frame/header_view.cc

Issue 2277563002: Wires up immersive mode for chrome and mash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix crash Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ash/common/frame/custom_frame_view_ash.h ('K') | « ash/common/frame/header_view.h ('k') | ash/mus/BUILD.gn » ('j') | ash/mus/frame/custom_frame_view_mus.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/frame/header_view.cc
diff --git a/ash/common/frame/header_view.cc b/ash/common/frame/header_view.cc
index 28d930c9266a75d2e2468d5afec50010816ce9f9..1f015ade4a9b6ba622318b71c3d5968a4997dca3 100644
--- a/ash/common/frame/header_view.cc
+++ b/ash/common/frame/header_view.cc
@@ -46,7 +46,7 @@ void HeaderView::ResetWindowControls() {
}
int HeaderView::GetPreferredOnScreenHeight() const {
- if (target_widget_->IsFullscreen()) {
+ if (is_immersive_delegate_ && target_widget_->IsFullscreen()) {
return static_cast<int>(GetPreferredHeight() *
fullscreen_visible_fraction_);
}
« ash/common/frame/custom_frame_view_ash.h ('K') | « ash/common/frame/header_view.h ('k') | ash/mus/BUILD.gn » ('j') | ash/mus/frame/custom_frame_view_mus.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698