Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2277543004: Converted Observatory script-inset & source-inset elements (Closed)

Created:
4 years, 4 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Converted script-inset, source-inset and eval-box elements Testing postponed R=johnmccutchan@google.com, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/c39868c8a52cd74d326e6b7caf4123a38585375d

Patch Set 1 #

Patch Set 2 : Fixing grammar error #

Patch Set 3 : Converted Observatory eval-box element #

Total comments: 2

Patch Set 4 : Fixed long line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2368 lines, -1631 lines) Patch
M runtime/observatory/lib/elements.dart View 1 2 8 chunks +15 lines, -3 lines 0 comments Download
M runtime/observatory/lib/elements.html View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/models.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_view.html View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 2 2 chunks +242 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/eval_box.dart View 1 2 1 chunk +173 lines, -46 lines 0 comments Download
D runtime/observatory/lib/src/elements/eval_box.html View 1 2 1 chunk +0 lines, -115 lines 0 comments Download
A runtime/observatory/lib/src/elements/eval_box_wrapper.dart View 1 2 1 chunk +130 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/heap_snapshot.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/helpers/any_ref.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.html View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_summary.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.html View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/library_view.html View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/objectstore_view.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/observatory_element.dart View 1 chunk +0 lines, -31 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.dart View 1 chunk +1122 lines, -1155 lines 0 comments Download
D runtime/observatory/lib/src/elements/script_inset.html View 1 chunk +0 lines, -223 lines 0 comments Download
A runtime/observatory/lib/src/elements/script_inset_wrapper.dart View 1 chunk +264 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_view.html View 1 chunk +0 lines, -1 line 0 comments Download
A runtime/observatory/lib/src/elements/source_inset.dart View 1 chunk +89 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/source_inset_wrapper.dart View 1 chunk +245 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/source_link.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/source_link_wrapper.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_view.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/models/objects/breakpoint.dart View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/models/objects/error.dart View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/models/objects/library.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/models/objects/script.dart View 1 chunk +7 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/models/objects/source_location.dart View 1 chunk +19 lines, -2 lines 0 comments Download
A + runtime/observatory/lib/src/models/repositories/eval.dart View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/models/repositories/script.dart View 1 chunk +1 line, -1 line 0 comments Download
A + runtime/observatory/lib/src/repositories/eval.dart View 1 2 1 chunk +6 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/repositories/script.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 7 chunks +9 lines, -7 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 5 chunks +6 lines, -2 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/script.dart View 1 chunk +10 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/repositories/script.dart View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
cbernaschina
4 years, 4 months ago (2016-08-24 21:56:25 UTC) #2
cbernaschina
4 years, 4 months ago (2016-08-24 23:09:42 UTC) #3
cbernaschina
4 years, 3 months ago (2016-08-25 02:21:36 UTC) #5
Cutch
LGTM but wait for Ryan / Todd's LGTM too.
4 years, 3 months ago (2016-08-25 22:20:36 UTC) #6
rmacnak
lgtm https://chromiumcodereview.appspot.com/2277543004/diff/40001/runtime/observatory/lib/src/models/objects/breakpoint.dart File runtime/observatory/lib/src/models/objects/breakpoint.dart (right): https://chromiumcodereview.appspot.com/2277543004/diff/40001/runtime/observatory/lib/src/models/objects/breakpoint.dart#newcode12 runtime/observatory/lib/src/models/objects/breakpoint.dart:12: /// [optional]Is this a breakpoint that was added ...
4 years, 3 months ago (2016-08-26 16:23:08 UTC) #7
cbernaschina
https://chromiumcodereview.appspot.com/2277543004/diff/40001/runtime/observatory/lib/src/models/objects/breakpoint.dart File runtime/observatory/lib/src/models/objects/breakpoint.dart (right): https://chromiumcodereview.appspot.com/2277543004/diff/40001/runtime/observatory/lib/src/models/objects/breakpoint.dart#newcode12 runtime/observatory/lib/src/models/objects/breakpoint.dart:12: /// [optional]Is this a breakpoint that was added synthetically ...
4 years, 3 months ago (2016-08-26 16:26:46 UTC) #8
cbernaschina
4 years, 3 months ago (2016-08-26 16:28:05 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
c39868c8a52cd74d326e6b7caf4123a38585375d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698