MD History: Replace more-vert iron-icon with styled divs.

MD History: Replace more-vert iron-icon with styled divs.

The end result is identical in appearance, but avoiding stamping
many small <iron-icon>s and SVGs saves 1-2% of page load time,
and also reduces the time taken to backfill offscreen items after
first paint.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ea829ba01d2d2d9c7498febbb860a22f2c7c7ae8
Cr-Commit-Position: refs/heads/master@{#413994}

[tsergeant, 2016-08-24 03:59:14]

Description was changed from

==========
MD History: Replace more-vert iron-icon with styled divs.

The end result is identical in appearance, but avoiding stamping
many small <iron-icon>s and SVGs saves 1-2% of page load time,
and also reduces the time taken to backfill offscreen items after
first paint.

BUG=629710
==========

to

==========
MD History: Replace more-vert iron-icon with styled divs.

The end result is identical in appearance, but avoiding stamping
many small <iron-icon>s and SVGs saves 1-2% of page load time,
and also reduces the time taken to backfill offscreen items after
first paint.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-08-24 04:01:09]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[calamity, 2016-08-24 04:39:33]

lgtm

[tsergeant, 2016-08-24 04:47:00]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-08-24 04:47:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-08-24 05:53:59]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-08-24 05:53:59]

https://codereview.chromium.org/2277543003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/shared_style.html (right):

https://codereview.chromium.org/2277543003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/shared_style.html:67:
button.more-vert-button {
nit: button.class doesn't really buy much more than .class

https://codereview.chromium.org/2277543003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/shared_style.html:78: transform: scale(0.8);
can you just change the 2px values to 1.6px instead of using the transform?

[Dan Beam, 2016-08-24 05:54:06]

lgtm either way

[tsergeant, 2016-08-24 05:58:08]

https://codereview.chromium.org/2277543003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/shared_style.html (right):

https://codereview.chromium.org/2277543003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/shared_style.html:78: transform: scale(0.8);
On 2016/08/24 05:53:59, Dan Beam wrote:
> can you just change the 2px values to 1.6px instead of using the transform?

We tried this, it doesn't work -- it seems to just round down the values to 1px.

[Dan Beam, 2016-08-24 06:05:04]

https://codereview.chromium.org/2277543003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/shared_style.html (right):

https://codereview.chromium.org/2277543003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/shared_style.html:78: transform: scale(0.8);
On 2016/08/24 05:58:08, tsergeant wrote:
> On 2016/08/24 05:53:59, Dan Beam wrote:
> > can you just change the 2px values to 1.6px instead of using the transform?
> 
> We tried this, it doesn't work -- it seems to just round down the values to
1px.

cool, still lgtm

[commit-bot: I haz the power, 2016-08-24 06:17:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-24 06:19:37]

Description was changed from

==========
MD History: Replace more-vert iron-icon with styled divs.

The end result is identical in appearance, but avoiding stamping
many small <iron-icon>s and SVGs saves 1-2% of page load time,
and also reduces the time taken to backfill offscreen items after
first paint.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Replace more-vert iron-icon with styled divs.

The end result is identical in appearance, but avoiding stamping
many small <iron-icon>s and SVGs saves 1-2% of page load time,
and also reduces the time taken to backfill offscreen items after
first paint.

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ea829ba01d2d2d9c7498febbb860a22f2c7c7ae8
Cr-Commit-Position: refs/heads/master@{#413994}
==========

[commit-bot: I haz the power, 2016-08-24 06:19:38]

Patchset 1 (id:??) landed as
https://crrev.com/ea829ba01d2d2d9c7498febbb860a22f2c7c7ae8
Cr-Commit-Position: refs/heads/master@{#413994}