Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2277543003: MD History: Replace more-vert iron-icon with styled divs. (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 4 months ago
Reviewers:
calamity, Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, Dan Beam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Replace more-vert iron-icon with styled divs. The end result is identical in appearance, but avoiding stamping many small <iron-icon>s and SVGs saves 1-2% of page load time, and also reduces the time taken to backfill offscreen items after first paint. BUG=629710 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ea829ba01d2d2d9c7498febbb860a22f2c7c7ae8 Cr-Commit-Position: refs/heads/master@{#413994}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -8 lines) Patch
M chrome/browser/resources/md_history/app.vulcanized.html View 3 chunks +22 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_history/history_item.html View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/shared_style.html View 1 chunk +14 lines, -0 lines 4 comments Download
M chrome/browser/resources/md_history/synced_device_card.html View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
tsergeant
4 years, 4 months ago (2016-08-24 04:01:09 UTC) #3
calamity
lgtm
4 years, 4 months ago (2016-08-24 04:39:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277543003/1
4 years, 4 months ago (2016-08-24 04:47:23 UTC) #6
Dan Beam
https://codereview.chromium.org/2277543003/diff/1/chrome/browser/resources/md_history/shared_style.html File chrome/browser/resources/md_history/shared_style.html (right): https://codereview.chromium.org/2277543003/diff/1/chrome/browser/resources/md_history/shared_style.html#newcode67 chrome/browser/resources/md_history/shared_style.html:67: button.more-vert-button { nit: button.class doesn't really buy much more ...
4 years, 4 months ago (2016-08-24 05:53:59 UTC) #8
Dan Beam
lgtm either way
4 years, 4 months ago (2016-08-24 05:54:06 UTC) #9
tsergeant
https://codereview.chromium.org/2277543003/diff/1/chrome/browser/resources/md_history/shared_style.html File chrome/browser/resources/md_history/shared_style.html (right): https://codereview.chromium.org/2277543003/diff/1/chrome/browser/resources/md_history/shared_style.html#newcode78 chrome/browser/resources/md_history/shared_style.html:78: transform: scale(0.8); On 2016/08/24 05:53:59, Dan Beam wrote: > ...
4 years, 4 months ago (2016-08-24 05:58:08 UTC) #10
Dan Beam
https://codereview.chromium.org/2277543003/diff/1/chrome/browser/resources/md_history/shared_style.html File chrome/browser/resources/md_history/shared_style.html (right): https://codereview.chromium.org/2277543003/diff/1/chrome/browser/resources/md_history/shared_style.html#newcode78 chrome/browser/resources/md_history/shared_style.html:78: transform: scale(0.8); On 2016/08/24 05:58:08, tsergeant wrote: > On ...
4 years, 4 months ago (2016-08-24 06:05:04 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 06:17:59 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 06:19:38 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea829ba01d2d2d9c7498febbb860a22f2c7c7ae8
Cr-Commit-Position: refs/heads/master@{#413994}

Powered by Google App Engine
This is Rietveld 408576698