DevTools: Simplify DOMBreakpointsSidebarPane inspected URL

DevTools: Simplify DOMBreakpointsSidebarPane inspected URL

Previously the restoreBreakpoints method implictly relied on the inspected URL being set
to the current inspected URL. This CL simplifies the logic for setting the inspected URL
and ensures that the inspected URL is always accurate in the process of restoring breakpoints.

BUG=627296, 634510
Committed: https://crrev.com/38ad51fd7da0f697fef9464ee0af4f9456cedf69
Cr-Commit-Position: refs/heads/master@{#414219}

[chenwilliam, 2016-08-23 22:40:49]

Description was changed from

==========
DevTools: Simplify DOMBreakpointsSidebarPane inspected URL

Previously the restoreBreakpoints method implictly relied on the inspected URL
being set
to the current inspected URL. This simplifies the logic for setting the
inspected URL
and ensures that the inspected URL is always accurate in the process of
restoring breakpoints.

BUG=627296
==========

to

==========
DevTools: Simplify DOMBreakpointsSidebarPane inspected URL

Previously the restoreBreakpoints method implictly relied on the inspected URL
being set
to the current inspected URL. This CL simplifies the logic for setting the
inspected URL
and ensures that the inspected URL is always accurate in the process of
restoring breakpoints.

BUG=627296
==========

[chenwilliam, 2016-08-23 22:40:49]

chenwilliam@chromium.org changed reviewers:
+ lushnikov@chromium.org

[chenwilliam, 2016-08-23 22:41:50]

Closed my previous CL https://codereview.chromium.org/2255983002/ in favor of a
small focused CL.

[lushnikov, 2016-08-23 23:26:07]

https://codereview.chromium.org/2277543002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
(right):

https://codereview.chromium.org/2277543002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js:372:
restoreBreakpoints: function(domModel, domDocument)
no need to pass domModel in here; you can get it from domDOcument

[chenwilliam, 2016-08-24 00:18:52]

Updated per feedback.

https://codereview.chromium.org/2277543002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js
(right):

https://codereview.chromium.org/2277543002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js:372:
restoreBreakpoints: function(domModel, domDocument)
On 2016/08/23 23:26:07, lushnikov wrote:
> no need to pass domModel in here; you can get it from domDOcument

Done.

[lushnikov, 2016-08-24 21:28:22]

lgtm

[chenwilliam, 2016-08-24 21:32:09]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2016-08-24 21:33:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 00:29:59]

Description was changed from

==========
DevTools: Simplify DOMBreakpointsSidebarPane inspected URL

Previously the restoreBreakpoints method implictly relied on the inspected URL
being set
to the current inspected URL. This CL simplifies the logic for setting the
inspected URL
and ensures that the inspected URL is always accurate in the process of
restoring breakpoints.

BUG=627296
==========

to

==========
DevTools: Simplify DOMBreakpointsSidebarPane inspected URL

Previously the restoreBreakpoints method implictly relied on the inspected URL
being set
to the current inspected URL. This CL simplifies the logic for setting the
inspected URL
and ensures that the inspected URL is always accurate in the process of
restoring breakpoints.

BUG=627296
==========

[commit-bot: I haz the power, 2016-08-25 00:30:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-25 00:31:34]

Description was changed from

==========
DevTools: Simplify DOMBreakpointsSidebarPane inspected URL

Previously the restoreBreakpoints method implictly relied on the inspected URL
being set
to the current inspected URL. This CL simplifies the logic for setting the
inspected URL
and ensures that the inspected URL is always accurate in the process of
restoring breakpoints.

BUG=627296
==========

to

==========
DevTools: Simplify DOMBreakpointsSidebarPane inspected URL

Previously the restoreBreakpoints method implictly relied on the inspected URL
being set
to the current inspected URL. This CL simplifies the logic for setting the
inspected URL
and ensures that the inspected URL is always accurate in the process of
restoring breakpoints.

BUG=627296

Committed: https://crrev.com/38ad51fd7da0f697fef9464ee0af4f9456cedf69
Cr-Commit-Position: refs/heads/master@{#414219}
==========

[commit-bot: I haz the power, 2016-08-25 00:31:35]

Patchset 2 (id:??) landed as
https://crrev.com/38ad51fd7da0f697fef9464ee0af4f9456cedf69
Cr-Commit-Position: refs/heads/master@{#414219}

[chenwilliam, 2016-08-29 19:49:35]

Description was changed from

==========
DevTools: Simplify DOMBreakpointsSidebarPane inspected URL

Previously the restoreBreakpoints method implictly relied on the inspected URL
being set
to the current inspected URL. This CL simplifies the logic for setting the
inspected URL
and ensures that the inspected URL is always accurate in the process of
restoring breakpoints.

BUG=627296

Committed: https://crrev.com/38ad51fd7da0f697fef9464ee0af4f9456cedf69
Cr-Commit-Position: refs/heads/master@{#414219}
==========

to

==========
DevTools: Simplify DOMBreakpointsSidebarPane inspected URL

Previously the restoreBreakpoints method implictly relied on the inspected URL
being set
to the current inspected URL. This CL simplifies the logic for setting the
inspected URL
and ensures that the inspected URL is always accurate in the process of
restoring breakpoints.

BUG=627296, 634510

Committed: https://crrev.com/38ad51fd7da0f697fef9464ee0af4f9456cedf69
Cr-Commit-Position: refs/heads/master@{#414219}
==========

[chenwilliam, 2016-08-29 19:52:14]

On 2016/08/25 00:31:35, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/38ad51fd7da0f697fef9464ee0af4f9456cedf69
> Cr-Commit-Position: refs/heads/master@{#414219}

Just remembered and verified that this fixes this bug: crbug.com/634510