chrome/browser/chromeos/arc/arc_navigation_throttle_unittest.cc - Issue 2277533002: Open |current_url| in Chrome when |previous_url| is empty

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chromeos/arc/arc_navigation_throttle_unittest.cc

Issue 2277533002: Open |current_url| in Chrome when |previous_url| is empty (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add unittest Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/chromeos/arc/arc_navigation_throttle.h"

	6 #include "testing/gtest/include/gtest/gtest.h"

	7 #include "url/gurl.h"

	8

	9 namespace arc {

	10

	11 TEST(ArcNavigationThrottleTest, TestShouldOverrideUrlLoading) {

	12 // A navigation within the same domain shouldn't be overwridden.
	Ben Kwa 2016/09/20 21:28:30 nit: "overridden" nit: "overridden" Yusuke Sato 2016/09/20 22:16:09 Done. Show quoted text On 2016/09/20 21:28:30, Ben Kwa wrote: > nit: "overridden" Done.
	13 EXPECT_FALSE(ArcNavigationThrottle::ShouldOverrideUrlLoadingForTesting(

	14 GURL("http://google.com"), GURL("http://google.com/")));

	15 EXPECT_FALSE(ArcNavigationThrottle::ShouldOverrideUrlLoadingForTesting(

	16 GURL("http://google.com"), GURL("http://a.google.com/")));

	17 EXPECT_FALSE(ArcNavigationThrottle::ShouldOverrideUrlLoadingForTesting(

	18 GURL("http://a.google.com"), GURL("http://google.com/")));

	19 EXPECT_FALSE(ArcNavigationThrottle::ShouldOverrideUrlLoadingForTesting(

	20 GURL("http://a.google.com"), GURL("http://b.google.com/")));

	21 EXPECT_FALSE(ArcNavigationThrottle::ShouldOverrideUrlLoadingForTesting(

	22 GURL("http://a.google.com"), GURL("http://b.c.google.com/")));

	23 EXPECT_FALSE(ArcNavigationThrottle::ShouldOverrideUrlLoadingForTesting(

	24 GURL("http://a.b.google.com"), GURL("http://c.google.com/")));

	25

	26 // If either of two paramters is empty, the fucntion should return false.
	Ben Kwa 2016/09/20 21:28:30 nit: "function" nit: "function" Yusuke Sato 2016/09/20 22:16:09 Done. Show quoted text On 2016/09/20 21:28:30, Ben Kwa wrote: > nit: "function" Done.
	27 EXPECT_FALSE(ArcNavigationThrottle::ShouldOverrideUrlLoadingForTesting(

	28 GURL(), GURL("http://a.google.com/")));

	29 EXPECT_FALSE(ArcNavigationThrottle::ShouldOverrideUrlLoadingForTesting(

	30 GURL("http://a.google.com/"), GURL()));

	31 EXPECT_FALSE(ArcNavigationThrottle::ShouldOverrideUrlLoadingForTesting(

	32 GURL(), GURL()));

	33

	34 // A navigation not within the same domain can be.
	Ben Kwa 2016/09/20 21:28:30 suggest: "can be overridden" suggest: "can be overridden" Yusuke Sato 2016/09/20 22:16:09 Done. Show quoted text On 2016/09/20 21:28:30, Ben Kwa wrote: > suggest: "can be overridden" Done.
	35 EXPECT_TRUE(ArcNavigationThrottle::ShouldOverrideUrlLoadingForTesting(

	36 GURL("http://www.google.com"), GURL("http://www.not-google.com/")));

	37 EXPECT_TRUE(ArcNavigationThrottle::ShouldOverrideUrlLoadingForTesting(

	38 GURL("http://www.not-google.com"), GURL("http://www.google.com/")));

	39 }

	40

	41 } // namespace arc

OLD	NEW

« no previous file with comments | « chrome/browser/chromeos/arc/arc_navigation_throttle.cc ('k') | no next file » | no next file with comments »