Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 227753002: don't use abi::__cxa_demangle in uclibc builds (Closed)

Created:
6 years, 8 months ago by Mostyn Bramley-Moore
Modified:
6 years, 8 months ago
CC:
blink-reviews, Mikhail, adamk+blink_chromium.org, Inactive, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

don't use abi::__cxa_demangle in uclibc builds abi::__cxa_demangle is glibc specific, it can't be used in uclibc builds. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171045

Patch Set 1 #

Patch Set 2 : bracket fixup #

Total comments: 2

Patch Set 3 : add more brackets for clarity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/wtf/Assertions.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Mostyn Bramley-Moore
@jochen, gavinp: PTAL...
6 years, 8 months ago (2014-04-07 19:48:35 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/227753002/diff/20001/Source/wtf/Assertions.cpp File Source/wtf/Assertions.cpp (right): https://codereview.chromium.org/227753002/diff/20001/Source/wtf/Assertions.cpp#newcode270 Source/wtf/Assertions.cpp:270: #if OS(MACOSX) || OS(LINUX) && !defined(__UCLIBC__) can you use ...
6 years, 8 months ago (2014-04-08 07:51:04 UTC) #2
Mostyn Bramley-Moore
https://codereview.chromium.org/227753002/diff/20001/Source/wtf/Assertions.cpp File Source/wtf/Assertions.cpp (right): https://codereview.chromium.org/227753002/diff/20001/Source/wtf/Assertions.cpp#newcode270 Source/wtf/Assertions.cpp:270: #if OS(MACOSX) || OS(LINUX) && !defined(__UCLIBC__) On 2014/04/08 07:51:04, ...
6 years, 8 months ago (2014-04-08 07:56:38 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-08 07:58:23 UTC) #4
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 8 months ago (2014-04-08 07:59:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/227753002/40001
6 years, 8 months ago (2014-04-08 07:59:24 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-08 09:00:45 UTC) #7
Message was sent while issue was closed.
Change committed as 171045

Powered by Google App Engine
This is Rietveld 408576698