chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java - Issue 2277523003: [NTP Snippets] Don't show the bookmark section if there are no bookmarks at all

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

Issue 2277523003: [NTP Snippets] Don't show the bookmark section if there are no bookmarks at all (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmark_empty_end

Patch Set: put behind variation param Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc » ('j') | components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

index 578c9307fec1c051120643e88b80a763090e6362..fd41b6cc2ea03bb72075b130b4b52c8e13b18ceb 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

@@ -192,8 +192,8 @@ public class SnippetsBridge implements SuggestionsSource {

@CalledByNative

private static SuggestionsCategoryInfo createSuggestionsCategoryInfo(

- String title, int cardLayout, boolean hasMoreButton, boolean hideIfEmpty) {

- return new SuggestionsCategoryInfo(title, cardLayout, hasMoreButton, hideIfEmpty);

+ String title, int cardLayout, boolean hasMoreButton, boolean showIfEmpty) {

+ return new SuggestionsCategoryInfo(title, cardLayout, hasMoreButton, showIfEmpty);

}

@CalledByNative