Update GrShape test to allow more flexible shape creation.

Update GrShape test to allow more flexible shape creation.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277483002

Committed: https://skia.googlesource.com/skia/+/a395f7c7a5a598a27528b30b0f1d112cdeeb4a9e

[bsalomon, 2016-08-23 21:22:49]

Description was changed from

==========
start on making geom in grshapetest virtual class

BUG=skia:
==========

to

==========
start on making geom in grshapetest virtual class

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277483002
==========

[bsalomon, 2016-08-24 17:24:26]

Patchset #1 (id:1) has been deleted

[bsalomon, 2016-08-24 17:25:15]

Description was changed from

==========
start on making geom in grshapetest virtual class

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277483002
==========

to

==========
Update GrShape test to allow more flexible shape creation.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277483002
==========

[bsalomon, 2016-08-24 17:25:15]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, robertphillips@google.com

[bsalomon, 2016-08-24 17:25:21]

https://codereview.chromium.org/2277483002/diff/20001/tests/GrShapeTest.cpp
File tests/GrShapeTest.cpp (left):

https://codereview.chromium.org/2277483002/diff/20001/tests/GrShapeTest.cpp#o...
tests/GrShapeTest.cpp:1740: SkPath circlePath;
These two (circlePath and rectPath) are subsumed into the rewrite of the SkRect
and SkRRect loops

https://codereview.chromium.org/2277483002/diff/20001/tests/GrShapeTest.cpp
File tests/GrShapeTest.cpp (right):

https://codereview.chromium.org/2277483002/diff/20001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:81: class Geo {
This class replaces the templated GEO types in the test functions below. The
template functions assumed that the GEO object could be passed as a GrShape
constructor arg. I wanted to make that more flexible for arcs. I plan to add
GrShape::MakeArc().

There were also a set of template functions that revealed whether a given GEO's
geometry would be transformed upon GrShape construction. Those are made members
of the new Geo class.

[robertphillips, 2016-08-24 23:00:58]

lgtm + 2 nits & some questions for my edification

https://codereview.chromium.org/2277483002/diff/20001/tests/GrShapeTest.cpp
File tests/GrShapeTest.cpp (right):

https://codereview.chromium.org/2277483002/diff/20001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:77: /**
Geom -> Geo ?
intputs -> inputs ?

https://codereview.chromium.org/2277483002/diff/20001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:114: // Converted to an outset rectangle.
Is the conversion of a stroke & fill rect w/ round caps to a rrect handled
somewhere?

Ideally shouldn't stroked and filled rects always be converted to some form of
filled geometry?

https://codereview.chromium.org/2277483002/diff/20001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:138: SkASSERT(paint.getStyle() ==
SkPaint::kStrokeAndFill_Style);
isCircle handling ?

[bsalomon, 2016-08-24 23:51:26]

https://codereview.chromium.org/2277483002/diff/20001/tests/GrShapeTest.cpp
File tests/GrShapeTest.cpp (right):

https://codereview.chromium.org/2277483002/diff/20001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:77: /**
On 2016/08/24 23:00:58, robertphillips wrote:
> Geom -> Geo ?
> intputs -> inputs ?

nah, I like intputs :)

https://codereview.chromium.org/2277483002/diff/20001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:114: // Converted to an outset rectangle.
On 2016/08/24 23:00:58, robertphillips wrote:
> Is the conversion of a stroke & fill rect w/ round caps to a rrect handled
> somewhere?
> 
> Ideally shouldn't stroked and filled rects always be converted to some form of
> filled geometry? 

Bevel and round joins aren't yet handled. They will come out to be a convex
geometry after stroking is applied, but there isn't a shortcut (yet).

https://codereview.chromium.org/2277483002/diff/20001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:138: SkASSERT(paint.getStyle() ==
SkPaint::kStrokeAndFill_Style);
On 2016/08/24 23:00:58, robertphillips wrote:
> isCircle handling ?

No, not yet. Definitely more to do here.

[bsalomon, 2016-08-24 23:51:30]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-08-24 23:51:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2277483002/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2016-08-24 23:51:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 00:47:43]

Description was changed from

==========
Update GrShape test to allow more flexible shape creation.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277483002
==========

to

==========
Update GrShape test to allow more flexible shape creation.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2277483002

Committed:
https://skia.googlesource.com/skia/+/a395f7c7a5a598a27528b30b0f1d112cdeeb4a9e
==========

[commit-bot: I haz the power, 2016-08-25 00:47:44]

Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/a395f7c7a5a598a27528b30b0f1d112cdeeb4a9e