Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: content/browser/devtools/devtools_agent_host_impl.cc

Issue 2277473007: Revert of DevTools: merge devtools target with devtools host, part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_agent_host_impl.cc
diff --git a/content/browser/devtools/devtools_agent_host_impl.cc b/content/browser/devtools/devtools_agent_host_impl.cc
index 055b4c4e2db8e3ce5bc57a1fbaf40d37bcbb9a1d..109dccd0976b10575a2da8af4ef673ccac31e8f5 100644
--- a/content/browser/devtools/devtools_agent_host_impl.cc
+++ b/content/browser/devtools/devtools_agent_host_impl.cc
@@ -32,14 +32,6 @@
LAZY_INSTANCE_INITIALIZER;
} // namespace
-char DevToolsAgentHost::kTypePage[] = "page";
-char DevToolsAgentHost::kTypeFrame[] = "frame";
-char DevToolsAgentHost::kTypeSharedWorker[] = "shared_worker";
-char DevToolsAgentHost::kTypeServiceWorker[] = "service_worker";
-char DevToolsAgentHost::kTypeExternal[] = "external";
-char DevToolsAgentHost::kTypeBrowser[] = "browser";
-char DevToolsAgentHost::kTypeOther[] = "other";
-
// static
std::string DevToolsAgentHost::GetProtocolVersion() {
return std::string(devtools::kProtocolVersion);
@@ -83,10 +75,7 @@
}
DevToolsAgentHostImpl::DevToolsAgentHostImpl()
- : id_(base::GenerateGUID()),
- session_id_(0),
- description_(""),
- client_(NULL) {
+ : id_(base::GenerateGUID()), session_id_(0), client_(NULL) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
g_instances.Get()[id_] = this;
}
@@ -177,27 +166,6 @@
return id_;
}
-std::string DevToolsAgentHostImpl::GetParentId() {
- return "";
-}
-
-std::string DevToolsAgentHostImpl::GetDescription() {
- return description_;
-}
-
-void DevToolsAgentHostImpl::SetDescriptionOverride(
- const std::string& description) {
- description_ = description;
-}
-
-GURL DevToolsAgentHostImpl::GetFaviconURL() {
- return GURL();
-}
-
-base::TimeTicks DevToolsAgentHostImpl::GetLastActivityTime() {
- return base::TimeTicks();
-}
-
BrowserContext* DevToolsAgentHostImpl::GetBrowserContext() {
return nullptr;
}
@@ -210,15 +178,6 @@
}
void DevToolsAgentHostImpl::ConnectWebContents(WebContents* wc) {
-}
-
-bool DevToolsAgentHostImpl::Inspect() {
- DevToolsManager* manager = DevToolsManager::GetInstance();
- if (manager->delegate()) {
- manager->delegate()->Inspect(this);
- return true;
- }
- return false;
}
void DevToolsAgentHostImpl::SendProtocolResponse(int session_id,
@@ -307,6 +266,15 @@
(*it)->Run(agent_host, attached);
}
+bool DevToolsAgentHostImpl::Inspect(BrowserContext* browser_context) {
+ DevToolsManager* manager = DevToolsManager::GetInstance();
+ if (manager->delegate()) {
+ manager->delegate()->Inspect(browser_context, this);
+ return true;
+ }
+ return false;
+}
+
// DevToolsMessageChunkProcessor -----------------------------------------------
DevToolsMessageChunkProcessor::DevToolsMessageChunkProcessor(
« no previous file with comments | « content/browser/devtools/devtools_agent_host_impl.h ('k') | content/browser/devtools/devtools_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698