Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2277473004: X87: TurboFan: Introduce TaggedSigned and TaggedPointer representations. (Closed)

Created:
4 years, 4 months ago by zhengxing.li
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: TurboFan: Introduce TaggedSigned and TaggedPointer representations. port d941b52d7328f6d223a1dc1ffb134221500dbb00 (r38657) original commit message: These new representations aren't used yet. BUG= Committed: https://crrev.com/32e7b9195b96fe65aed9792b054c298f0734c5e3 Cr-Commit-Position: refs/heads/master@{#38849}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 4 chunks +18 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 4 months ago (2016-08-24 01:59:17 UTC) #2
Weiliang
lgtm
4 years, 4 months ago (2016-08-24 02:11:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277473004/1
4 years, 4 months ago (2016-08-24 02:12:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 02:37:41 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 02:38:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32e7b9195b96fe65aed9792b054c298f0734c5e3
Cr-Commit-Position: refs/heads/master@{#38849}

Powered by Google App Engine
This is Rietveld 408576698