Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2277453003: Make MockHostResolverProc destructor protected. (Closed)

Created:
4 years, 4 months ago by Bernhard Bauer
Modified:
4 years, 4 months ago
Reviewers:
Julia Tuttle
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make MockHostResolverProc destructor protected. This avoids a chromium-style error in Clang (e.g. https://uberchromegw.corp.google.com/i/internal.client.clank/builders/clang-builder/builds/6977/steps/compile/logs/stdio). TBR=juliatuttle@chromium.org Committed: https://crrev.com/d9725d2ebefab2808e24e7457b4b29655ed44274 Cr-Commit-Position: refs/heads/master@{#414058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M components/cronet/stale_host_resolver_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277453003/1
4 years, 4 months ago (2016-08-24 12:19:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 12:59:47 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 13:03:21 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9725d2ebefab2808e24e7457b4b29655ed44274
Cr-Commit-Position: refs/heads/master@{#414058}

Powered by Google App Engine
This is Rietveld 408576698