Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1647)

Unified Diff: core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h

Issue 2277433003: Move parser out of IndirectObjectHolder (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@private_objs
Patch Set: Fix merge Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h
diff --git a/core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h b/core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h
index 27a9bc39db54dea0859608a63eca897165b0a603..57dafb05280253ba16b94561f213e634244a1a32 100644
--- a/core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h
+++ b/core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h
@@ -12,15 +12,14 @@
#include "core/fxcrt/include/fx_system.h"
class CPDF_Object;
-class CPDF_Parser;
class CPDF_IndirectObjectHolder {
public:
using iterator = std::map<uint32_t, CPDF_Object*>::iterator;
using const_iterator = std::map<uint32_t, CPDF_Object*>::const_iterator;
- explicit CPDF_IndirectObjectHolder(CPDF_Parser* pParser);
- ~CPDF_IndirectObjectHolder();
+ CPDF_IndirectObjectHolder();
+ virtual ~CPDF_IndirectObjectHolder();
CPDF_Object* GetIndirectObject(uint32_t objnum) const;
CPDF_Object* GetOrParseIndirectObject(uint32_t objnum);
@@ -40,7 +39,7 @@ class CPDF_IndirectObjectHolder {
const_iterator end() const { return m_IndirectObjs.end(); }
protected:
- CPDF_Parser* m_pParser;
+ virtual CPDF_Object* ParseIndirectObject(uint32_t objnum);
private:
uint32_t m_LastObjNum;

Powered by Google App Engine
This is Rietveld 408576698