core/fpdfapi/fpdf_parser/cpdf_parser.cpp - Issue 2277433003: Move parser out of IndirectObjectHolder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_parser.cpp

Issue 2277433003: Move parser out of IndirectObjectHolder (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@private_objs

Patch Set: Fix merge Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_parser.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_parser.cpp b/core/fpdfapi/fpdf_parser/cpdf_parser.cpp

index 26adf7bb137eaf350de286d832569f856bd56235..ffd3f79a621955629271fa7935d667a109021d72 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_parser.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_parser.cpp

@@ -982,6 +982,8 @@ FX_BOOL CPDF_Parser::LoadCrossRefV5(FX_FILESIZE* pos, FX_BOOL bMainXRef) {

if (m_pDocument) {

CPDF_Dictionary* pRootDict = m_pDocument->GetRoot();

if (pRootDict && pRootDict->GetObjNum() == pObject->m_ObjNum) {

+ // If |pObject| has an objnum assigned then this will leak as Release()

+ // will early exit.

if (pObject->IsStream())

pObject->Release();

return FALSE;