core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp - Issue 2277433003: Move parser out of IndirectObjectHolder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp

Issue 2277433003: Move parser out of IndirectObjectHolder (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@private_objs

Patch Set: Fix merge Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp b/core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp

index 41a49cadaba69fb501d0dc7955862c1f15cc571e..ef9b65c5c49662e5600aafced3f00b318e705634 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_array_unittest.cpp

@@ -109,7 +109,7 @@ TEST(cpdf_array, Clone) {

ScopedArray arr(new CPDF_Array);

// Indirect references to indirect objects.

std::unique_ptr<CPDF_IndirectObjectHolder> obj_holder(

- new CPDF_IndirectObjectHolder(nullptr));

+ new CPDF_IndirectObjectHolder());

for (size_t i = 0; i < kNumOfRows; ++i) {

CPDF_Array* arr_elem = new CPDF_Array;

for (size_t j = 0; j < kNumOfRowElems; ++j) {