Defer allocation in cc::ContiguousContainerBase::Buffer.

cc/base/contiguous_container_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "cc/base/contiguous_container.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 492 matching lines @@
 TEST(ContiguousContainerTest, CapacityInBytesAfterClear) {
   // Clearing should restore the capacity of the container to the same as a
   // newly allocated one (without reserved capacity requested).
   ContiguousContainer<Point2D, kPointAlignment> list(kMaxPointSize);
   size_t empty_capacity = list.GetCapacityInBytes();
   list.AllocateAndConstruct<Point2D>();
   list.AllocateAndConstruct<Point2D>();
   list.Clear();
   EXPECT_EQ(empty_capacity, list.GetCapacityInBytes());
 }
 

[danakj, 2016/08/23 18:16:00]

Can you add a test that verifies we can use begin() and end() to iterate over
the empty container before anything was allocated? It should iterate 0 times and
not crash.

[Dmitry Skiba, 2016/08/24 17:58:46]

Done.

+TEST(ContiguousContainerTest, MemoryUsageInBytes) {
+  constexpr size_t initial_size1 = 10 * kMaxPointSize;
+  ContiguousContainer<Point2D, kPointAlignment> list1(kMaxPointSize,
+                                                      initial_size1);
+
+  constexpr size_t initial_size2 = 10000 * kMaxPointSize;
+  ContiguousContainer<Point2D, kPointAlignment> list2(kMaxPointSize,
+                                                      initial_size2);
+
+  // Memory is allocated lazily, so even though lists were created with
+  // different initial_size values, they'll have the same memory size here.
+  EXPECT_EQ(list1.MemoryUsageInBytes(), list2.MemoryUsageInBytes());

[danakj, 2016/08/23 18:16:00]

You could check LT initial_size here?

[Dmitry Skiba, 2016/08/24 17:58:46]

I think that checking that would make us depend on internal implementation
details. For example in the constructor we append one element to 
ContiguousContainer::elements_, and that pushes memory usage to some
implementation-defined levels (elements_.capacity()).

I did change the checks to make sure memory usage grows by at least initial_size
though.

+
+  // Trigger memory allocation.
+  list1.AllocateAndConstruct<Point2D>();
+  list2.AllocateAndConstruct<Point2D>();
+
+  // Same object was created in both lists, but their memory sizes grew
+  // differently, based on initial_size values lists were created with.
+  EXPECT_NE(list1.MemoryUsageInBytes(), list2.MemoryUsageInBytes());
+
+  // Since memory size also includes other things, it should be greater
+  // than initial_size value.
+  EXPECT_GT(list1.MemoryUsageInBytes(), initial_size1);
+  EXPECT_GT(list2.MemoryUsageInBytes(), initial_size2);
+}
+
 TEST(ContiguousContainerTest, Alignment) {
   const size_t max_align = ALIGNOF(long double);
   ContiguousContainer<Point2D, max_align> list(kMaxPointSize);
 
   list.AllocateAndConstruct<Point2D>();
   EXPECT_EQ(0u, reinterpret_cast<intptr_t>(&list.last()) & (max_align - 1));
   list.AllocateAndConstruct<Point2D>();
   EXPECT_EQ(0u, reinterpret_cast<intptr_t>(&list.last()) & (max_align - 1));
   list.AllocateAndConstruct<Point3D>();
   EXPECT_EQ(0u, reinterpret_cast<intptr_t>(&list.last()) & (max_align - 1));
   list.AllocateAndConstruct<Point3D>();
   EXPECT_EQ(0u, reinterpret_cast<intptr_t>(&list.last()) & (max_align - 1));
   list.AllocateAndConstruct<Point2D>();
   EXPECT_EQ(0u, reinterpret_cast<intptr_t>(&list.last()) & (max_align - 1));
 
   list.AppendByMoving(&list[0], sizeof(Point2D));
   EXPECT_EQ(0u, reinterpret_cast<intptr_t>(&list.last()) & (max_align - 1));
   list.AppendByMoving(&list[1], sizeof(Point2D));
   EXPECT_EQ(0u, reinterpret_cast<intptr_t>(&list.last()) & (max_align - 1));
   list.AppendByMoving(&list[2], sizeof(Point3D));
   EXPECT_EQ(0u, reinterpret_cast<intptr_t>(&list.last()) & (max_align - 1));
   list.AppendByMoving(&list[3], sizeof(Point3D));
   EXPECT_EQ(0u, reinterpret_cast<intptr_t>(&list.last()) & (max_align - 1));
   list.AppendByMoving(&list[4], sizeof(Point2D));
   EXPECT_EQ(0u, reinterpret_cast<intptr_t>(&list.last()) & (max_align - 1));
 }
 
 }  // namespace
 }  // namespace cc