content/renderer/media/media_stream_dependency_factory.cc - Issue 227743004: Added a kEchoCancellation constraint to turn off the audio processing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_dependency_factory.cc

Issue 227743004: Added a kEchoCancellation constraint to turn off the audio processing. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: when kEchoCancellation is false, default values of all goog* constraints are false, added unittests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_audio_processor_unittest.cc ('K') | « content/renderer/media/media_stream_constraints_util_unittest.cc ('k') | content/renderer/media/media_stream_source.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_dependency_factory.cc

diff --git a/content/renderer/media/media_stream_dependency_factory.cc b/content/renderer/media/media_stream_dependency_factory.cc

index 0b13677591bdc9f112b074d380a6557030c8c5a8..0ad9dbe544cc16f9d29fc5e03c6763cff9c5e627 100644

--- a/content/renderer/media/media_stream_dependency_factory.cc

+++ b/content/renderer/media/media_stream_dependency_factory.cc

@@ -193,7 +193,7 @@ bool MediaStreamDependencyFactory::InitializeMediaStreamAudioSource(

// Do additional source initialization if the audio source is a valid

// microphone or tab audio.

RTCMediaConstraints native_audio_constraints(audio_constraints);

- ApplyFixedAudioConstraints(&native_audio_constraints);

+ MediaAudioConstraints::ApplyFixedAudioConstraints(&native_audio_constraints);

StreamDeviceInfo device_info = source_data->device_info();

RTCMediaConstraints constraints = native_audio_constraints;