content/renderer/media/webrtc_local_audio_source_provider_unittest.cc - Issue 227743004: Added a kEchoCancellation constraint to turn off the audio processing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_local_audio_source_provider_unittest.cc

Issue 227743004: Added a kEchoCancellation constraint to turn off the audio processing. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: moved some of the constraints code to MediaAudioConstraints class, and hope it makes the code more … Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/webrtc_audio_capturer.cc ('K') | « content/renderer/media/webrtc_audio_capturer_unittest.cc ('k') | content/renderer/media/webrtc_local_audio_track_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc_local_audio_source_provider_unittest.cc

diff --git a/content/renderer/media/webrtc_local_audio_source_provider_unittest.cc b/content/renderer/media/webrtc_local_audio_source_provider_unittest.cc

index 8b0fd6b27c157e9ce14da82c82b8d83f0135de39..664904e2da5735f0481d7413e7486a0a91ec419c 100644

--- a/content/renderer/media/webrtc_local_audio_source_provider_unittest.cc

+++ b/content/renderer/media/webrtc_local_audio_source_provider_unittest.cc

@@ -4,6 +4,7 @@

#include "base/logging.h"

#include "base/strings/utf_string_conversions.h"

+#include "content/renderer/media/mock_media_constraint_factory.h"

#include "content/renderer/media/webrtc/webrtc_local_audio_track_adapter.h"

#include "content/renderer/media/webrtc_audio_capturer.h"

#include "content/renderer/media/webrtc_local_audio_source_provider.h"

@@ -11,7 +12,6 @@

#include "media/audio/audio_parameters.h"

#include "media/base/audio_bus.h"

#include "testing/gtest/include/gtest/gtest.h"

-#include "third_party/WebKit/public/platform/WebMediaConstraints.h"

#include "third_party/WebKit/public/platform/WebMediaStreamTrack.h"

namespace content {

@@ -29,10 +29,11 @@ class WebRtcLocalAudioSourceProviderTest : public testing::Test {

source_params_.frames_per_buffer() * source_params_.channels();

source_data_.reset(new int16[length]);

sink_bus_ = media::AudioBus::Create(sink_params_);

- blink::WebMediaConstraints constraints;

- scoped_refptr<WebRtcAudioCapturer> capturer(

- WebRtcAudioCapturer::CreateCapturer(-1, StreamDeviceInfo(),

- constraints, NULL));

+ MockMediaConstraintFactory constraint_factory;

+ scoped_refptr<WebRtcAudioCapturer> capturer(

+ WebRtcAudioCapturer::CreateCapturer(

+ -1, StreamDeviceInfo(),

+ constraint_factory.CreateWebMediaConstraints(), NULL));

scoped_refptr<WebRtcLocalAudioTrackAdapter> adapter(

WebRtcLocalAudioTrackAdapter::Create(std::string(), NULL));

scoped_ptr<WebRtcLocalAudioTrack> native_track(