content/renderer/media/webrtc_audio_capturer_unittest.cc - Issue 227743004: Added a kEchoCancellation constraint to turn off the audio processing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_audio_capturer_unittest.cc

Issue 227743004: Added a kEchoCancellation constraint to turn off the audio processing. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: moved some of the constraints code to MediaAudioConstraints class, and hope it makes the code more … Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/webrtc_audio_capturer.cc ('K') | « content/renderer/media/webrtc_audio_capturer.cc ('k') | content/renderer/media/webrtc_local_audio_source_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc_audio_capturer_unittest.cc

diff --git a/content/renderer/media/webrtc_audio_capturer_unittest.cc b/content/renderer/media/webrtc_audio_capturer_unittest.cc

index d0bcf296c6042413fc3785809ea3fa5c731a1ae3..b93cecb1b1698c850a982689dfe1cc58848f96da 100644

--- a/content/renderer/media/webrtc_audio_capturer_unittest.cc

+++ b/content/renderer/media/webrtc_audio_capturer_unittest.cc

@@ -158,8 +158,8 @@ class WebRtcAudioCapturerTest : public testing::Test {

// those values should be correctly stored and passed to the track.

TEST_F(WebRtcAudioCapturerTest, VerifyAudioParams) {

// Use constraints with default settings.

- blink::WebMediaConstraints constraints;

- VerifyAudioParams(constraints, true);

+ MockMediaConstraintFactory constraint_factory;

+ VerifyAudioParams(constraint_factory.CreateWebMediaConstraints(), true);

}

TEST_F(WebRtcAudioCapturerTest, VerifyAudioParamsWithAudioProcessing) {