content/renderer/media/mock_media_constraint_factory.h - Issue 227743004: Added a kEchoCancellation constraint to turn off the audio processing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/mock_media_constraint_factory.h

Issue 227743004: Added a kEchoCancellation constraint to turn off the audio processing. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: moved some of the constraints code to MediaAudioConstraints class, and hope it makes the code more … Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_video_source.cc ('K') | « content/renderer/media/media_stream_video_source.cc ('k') | content/renderer/media/mock_media_constraint_factory.cc » ('j') | content/renderer/media/webrtc_audio_capturer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/mock_media_constraint_factory.h

diff --git a/content/renderer/media/mock_media_constraint_factory.h b/content/renderer/media/mock_media_constraint_factory.h

index 6eb261a42f71afde5123ac39272761f88607cfe5..5c9f7f533c913d91b591366200ad072b0a0074e6 100644

--- a/content/renderer/media/mock_media_constraint_factory.h

+++ b/content/renderer/media/mock_media_constraint_factory.h

@@ -20,8 +20,10 @@ class MockMediaConstraintFactory {

blink::WebMediaConstraints CreateWebMediaConstraints();

void AddMandatory(const std::string& key, int value);

void AddMandatory(const std::string& key, double value);

+ void AddMandatory(const std::string& key, const std::string& value);

void AddOptional(const std::string& key, int value);

void AddOptional(const std::string& key, double value);

+ void AddOptional(const std::string& key, const std::string& value);

void DisableDefaultAudioConstraints();

private: