content/renderer/media/webrtc_audio_capturer.cc - Issue 227743004: Added a kEchoCancellation constraint to turn off the audio processing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_audio_capturer.cc

Issue 227743004: Added a kEchoCancellation constraint to turn off the audio processing. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: addressed the comments. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/webrtc/webrtc_local_audio_track_adapter_unittest.cc ('K') | « content/renderer/media/webrtc/webrtc_local_audio_track_adapter_unittest.cc ('k') | content/renderer/media/webrtc_audio_capturer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc_audio_capturer.cc

diff --git a/content/renderer/media/webrtc_audio_capturer.cc b/content/renderer/media/webrtc_audio_capturer.cc

index 7318cba1ba5e32b5c89f6aacfc41fa94f2106f9e..0f3f52605cdfb1b854ccb02f0e6066b7149b2952 100644

--- a/content/renderer/media/webrtc_audio_capturer.cc

+++ b/content/renderer/media/webrtc_audio_capturer.cc

@@ -156,6 +156,11 @@ bool WebRtcAudioCapturer::Initialize() {

return true;

}

+ if (!IsValid(constraints_)) {

+ DLOG(ERROR) << "Constraints contain invalid mandatory keys";

+ return false;

+ }

media::ChannelLayout channel_layout = static_cast<media::ChannelLayout>(

device_info_.device.input.channel_layout);

DVLOG(1) << "Audio input hardware channel layout: " << channel_layout;

@@ -213,8 +218,7 @@ WebRtcAudioCapturer::WebRtcAudioCapturer(

: constraints_(constraints),

audio_processor_(

new talk_base::RefCountedObject<MediaStreamAudioProcessor>(

- constraints, device_info.device.input.effects,

- device_info.device.type, audio_device)),

+ constraints, device_info.device.input.effects, audio_device)),

running_(false),

render_view_id_(render_view_id),

device_info_(device_info),