Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Side by Side Diff: content/renderer/media/media_stream_constraints_util.cc

Issue 227743004: Added a kEchoCancellation constraint to turn off the audio processing. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: addressed Tommi's comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "content/renderer/media/media_stream_constraints_util.h"
6
7 #include "base/strings/string_number_conversions.h"
8 #include "base/strings/utf_string_conversions.h"
9 #include "third_party/WebKit/public/platform/WebMediaConstraints.h"
10 #include "third_party/WebKit/public/platform/WebString.h"
11
12 namespace content {
13
14 namespace {
15
16 // Convert a string ("true", "false") to a boolean.
17 bool ConvertStringToBoolean(const std::string& string, bool* value) {
18 static const char kValueTrue[] = "true";
19 static const char kValueFalse[] = "false";
20
21 *value = (string == kValueTrue);
22 return *value || (string == kValueFalse);
23 }
24
25 } // namespace
26
27 bool GetConstraintValueAsBoolean(const blink::WebMediaConstraints& constraints,
28 const std::string& key,
29 bool* value) {
30 return GetMandatoryConstraintValueAsBoolean(constraints, key, value) ||
31 GetOptionalConstraintValueAsBoolean(constraints, key, value);
32 }
33
34 bool GetConstraintValueAsInteger(const blink::WebMediaConstraints& constraints,
35 const std::string& key,
36 int* value) {
37 return GetMandatoryConstraintValueAsInteger(constraints, key, value) ||
38 GetOptionalConstraintValueAsInteger(constraints, key, value);
39 }
40
41 bool GetConstraintValueAsString(const blink::WebMediaConstraints& constraints,
42 const std::string& key,
43 std::string* value) {
44 blink::WebString value_str;
45 base::string16 key_16 = base::UTF8ToUTF16(key);
46 if (!constraints.getMandatoryConstraintValue(key_16, value_str) &&
47 !constraints.getOptionalConstraintValue(key_16, value_str)) {
48 return false;
49 }
50
51 *value = value_str.utf8();
52 return true;
53 }
54
55 bool GetMandatoryConstraintValueAsBoolean(
56 const blink::WebMediaConstraints& constraints,
57 const std::string& key,
58 bool* value) {
59 blink::WebString value_str;
60 if (!constraints.getMandatoryConstraintValue(base::UTF8ToUTF16(key),
61 value_str)) {
62 return false;
63 }
64
65 return ConvertStringToBoolean(value_str.utf8(), value);
66 }
67
68 bool GetMandatoryConstraintValueAsInteger(
69 const blink::WebMediaConstraints& constraints,
70 const std::string& key,
71 int* value) {
72 blink::WebString value_str;
73 if (!constraints.getMandatoryConstraintValue(base::UTF8ToUTF16(key),
74 value_str)) {
75 return false;
76 }
77
78 return base::StringToInt(value_str.utf8(), value);
perkj_chrome 2014/05/08 13:42:24 Humm - you are aware that there is a difference be
no longer working on chromium 2014/05/12 14:39:09 Added a GetMandatoryConstraintValueAsBoolean(key)
79 }
80
81 bool GetOptionalConstraintValueAsBoolean(
82 const blink::WebMediaConstraints& constraints,
83 const std::string& key,
84 bool* value) {
85 blink::WebString value_str;
86 if (!constraints.getOptionalConstraintValue(base::UTF8ToUTF16(key),
87 value_str)) {
88 return false;
89 }
90
91 return ConvertStringToBoolean(value_str.utf8(), value);
92 }
93
94 bool GetOptionalConstraintValueAsInteger(
95 const blink::WebMediaConstraints& constraints,
96 const std::string& key,
97 int* value) {
98 blink::WebString value_str;
99 if (!constraints.getOptionalConstraintValue(base::UTF8ToUTF16(key),
100 value_str)) {
101 return false;
102 }
103
104 return base::StringToInt(value_str.utf8(), value);
105 }
106
107 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698