Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2277403003: Make cr.icon.getSupportedScaleFactors slightly closer to the .cc version. (Closed)

Created:
4 years, 3 months ago by Peter Kasting
Modified:
4 years, 3 months ago
Reviewers:
tommycli, oshima, michaelpg
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make cr.icon.getSupportedScaleFactors slightly closer to the .cc version. This should only affect Android, and should, I think, have little if any visible effect, since if the browser side can't satisfy the high-DPI version of the request it will automatically fall back to the low version anyway. BUG=none TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/53e7734771c2f9a2273b53f80902957c771df258 Cr-Commit-Position: refs/heads/master@{#416387}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M ui/webui/resources/js/icon.js View 1 chunk +11 lines, -7 lines 0 comments Download

Messages

Total messages: 32 (14 generated)
Peter Kasting
Do you think this is worth doing? I am not fixing any particular bug. I ...
4 years, 3 months ago (2016-08-26 05:09:39 UTC) #5
oshima
On 2016/08/26 05:09:39, Peter Kasting wrote: > Do you think this is worth doing? > ...
4 years, 3 months ago (2016-08-26 21:36:19 UTC) #8
Peter Kasting
On 2016/08/26 21:36:19, oshima wrote: > On 2016/08/26 05:09:39, Peter Kasting wrote: > > Do ...
4 years, 3 months ago (2016-08-27 04:25:47 UTC) #9
Peter Kasting
(Still waiting for your reply before proceeding further here)
4 years, 3 months ago (2016-09-01 22:13:31 UTC) #10
oshima
On 2016/09/01 22:13:31, Peter Kasting wrote: > (Still waiting for your reply before proceeding further ...
4 years, 3 months ago (2016-09-02 00:32:44 UTC) #11
Peter Kasting
On 2016/09/02 00:32:44, oshima wrote: > On 2016/09/01 22:13:31, Peter Kasting wrote: > > (Still ...
4 years, 3 months ago (2016-09-02 00:44:03 UTC) #12
oshima
slgtm Let's land this first to keep the logic in sync. I'll then remove 1.0f ...
4 years, 3 months ago (2016-09-02 13:43:39 UTC) #13
oshima
On 2016/09/02 13:43:39, oshima wrote: > slgtm > > Let's land this first to keep ...
4 years, 3 months ago (2016-09-02 13:44:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277403003/1
4 years, 3 months ago (2016-09-02 19:18:34 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/252339)
4 years, 3 months ago (2016-09-02 19:25:17 UTC) #18
Peter Kasting
+tommycli for OWNERS
4 years, 3 months ago (2016-09-02 19:46:04 UTC) #20
michaelpg
lgtm on the basis of oshima's lgtm
4 years, 3 months ago (2016-09-02 20:25:22 UTC) #22
tommycli
also no objections. lgtm
4 years, 3 months ago (2016-09-02 20:26:18 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277403003/1
4 years, 3 months ago (2016-09-02 20:26:19 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/273962)
4 years, 3 months ago (2016-09-02 21:35:04 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277403003/1
4 years, 3 months ago (2016-09-02 22:28:48 UTC) #29
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 23:35:27 UTC) #30
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 23:38:19 UTC) #32
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53e7734771c2f9a2273b53f80902957c771df258
Cr-Commit-Position: refs/heads/master@{#416387}

Powered by Google App Engine
This is Rietveld 408576698