Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2277373002: [Extensions] Make UserScriptInjector's script update stricter (Closed)

Created:
4 years, 3 months ago by Devlin
Modified:
4 years, 3 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Make UserScriptInjector's script update stricter When user scripts are updated in the renderer, all old scripts are invalidated. Ensure that we don't UAF and have a valid user script object in the injector after the update. BUG=None Committed: https://crrev.com/dd7a63a41e5db0b2a8cb217a4063a33c19398a6e Cr-Commit-Position: refs/heads/master@{#415200}

Patch Set 1 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M extensions/renderer/user_script_injector.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M extensions/renderer/user_script_set.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Devlin
4 years, 3 months ago (2016-08-25 21:11:58 UTC) #10
lazyboy
lgtm. For some reason, I've not noticed this CL.
4 years, 3 months ago (2016-08-29 17:45:16 UTC) #11
Devlin
On 2016/08/29 17:45:16, lazyboy wrote: > For some reason, I've not noticed this CL. No ...
4 years, 3 months ago (2016-08-29 18:05:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277373002/40001
4 years, 3 months ago (2016-08-29 18:24:06 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 3 months ago (2016-08-30 06:07:37 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 06:10:31 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd7a63a41e5db0b2a8cb217a4063a33c19398a6e
Cr-Commit-Position: refs/heads/master@{#415200}

Powered by Google App Engine
This is Rietveld 408576698