Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2277353002: [sensors] Drop DEVICE_SENSOR_EXPORT macro (Closed)

Created:
4 years, 3 months ago by Mikhail
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sensors] Drop DEVICE_SENSOR_EXPORT macro It is not needed as 'generic_sensor' is build as a source set and it causes linker warnings on windows component build. BUG=640769 Committed: https://crrev.com/4aad6e77c7623fc2dd41404f8c6bc0ec55192826 Cr-Commit-Position: refs/heads/master@{#414714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -41 lines) Patch
M device/generic_sensor/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M device/generic_sensor/platform_sensor_configuration.h View 1 chunk +1 line, -2 lines 0 comments Download
M device/generic_sensor/public/interfaces/sensor.typemap View 1 chunk +1 line, -4 lines 0 comments Download
D device/generic_sensor/sensor_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
M device/generic_sensor/sensor_provider_impl.h View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Mikhail
PTAL
4 years, 3 months ago (2016-08-25 20:01:17 UTC) #8
Ken Rockot(use gerrit already)
lgtm
4 years, 3 months ago (2016-08-26 14:25:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277353002/1
4 years, 3 months ago (2016-08-26 14:29:08 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 15:07:07 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4aad6e77c7623fc2dd41404f8c6bc0ec55192826 Cr-Commit-Position: refs/heads/master@{#414714}
4 years, 3 months ago (2016-08-26 15:09:04 UTC) #15
timvolodine
On 2016/08/26 15:09:04, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 3 months ago (2016-08-30 12:56:55 UTC) #16
Mikhail
4 years, 3 months ago (2016-08-31 08:19:47 UTC) #17
Message was sent while issue was closed.
On 2016/08/30 12:56:55, timvolodine wrote:
> On 2016/08/26 15:09:04, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/4aad6e77c7623fc2dd41404f8c6bc0ec55192826
> > Cr-Commit-Position: refs/heads/master@{#414714}
> 
> mikhail@ : maybe just make it a 'component' in the future? it seems code in
> device/.. is usually written as 'component' with the appropriate _export.h
etc..

I did not find any common guideline reg this, the way device/ subfolders are
build actually varies (e.g. 'usb' is also build as a static library).
It should not be a problem however to make 'generic_device' a 'component' if
there will be a need for this in future.

Powered by Google App Engine
This is Rietveld 408576698