Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2277343002: Refactor update_w3c_test_expectations. (Closed)

Created:
4 years, 3 months ago by qyearsley
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor update_w3c_test_expectations. In this CL: - Move main() logic into a method in W3CExpectationsLineAdder. - Use existing BuildBot instance from host. - Make an instance of WebKitFinder in the constructor to avoid having to pass it to multiple functions. - Decrease the number of args passed around when possible. - Make attributes which are referenced in the test non-protected. Committed: https://crrev.com/bd35b4bf4884541325c0b91f0e8e31249f05457e Cr-Commit-Position: refs/heads/master@{#414551}

Patch Set 1 #

Patch Set 2 : Fix comments #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -102 lines) Patch
M third_party/WebKit/Tools/Scripts/update-w3c-test-expectations View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py View 1 2 10 chunks +61 lines, -68 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py View 1 2 4 chunks +30 lines, -32 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
qyearsley
4 years, 3 months ago (2016-08-25 17:22:28 UTC) #2
Dirk Pranke
lgtm
4 years, 3 months ago (2016-08-25 17:27:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277343002/40001
4 years, 3 months ago (2016-08-25 20:37:33 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-25 22:05:58 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 22:08:24 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bd35b4bf4884541325c0b91f0e8e31249f05457e
Cr-Commit-Position: refs/heads/master@{#414551}

Powered by Google App Engine
This is Rietveld 408576698