Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 2277333002: Revert of Remove MessageLoop::current() from base::win::ObjectWatcher. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org, jschuh
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove MessageLoop::current() from base::win::ObjectWatcher. (patchset #5 id:80001 of https://codereview.chromium.org/2125763003/ ) Reason for revert: Breaks Win10 builder. crbug.com/632184 Original issue's description: > Remove MessageLoop::current() from base::win::ObjectWatcher. > > Why? The fact that there's a MessageLoop on the thread is an > unnecessary implementation detail. When browser threads are migrated to > base/task_scheduler, tasks will no longer have access to a MessageLoop > but they will be able to get the current ThreadTaskRunnerHandle. > > Before this CL, ObjectWatcher implemented > WillDestroyCurrentMessageLoop() to stop the watch when the > MessageLoop responsible for running the callback was destroyed. > This prevented the watch callback from being sent to a destroyed > MessageLoop. > > Now that ObjectWatcher keeps a reference to a TaskRunner, this is > no longer required. The TaskRunner can't be deleted while there are > references to it. If the underlying MessageLoop has been deleted > when the watch callback is posted, the callback will simply not run. > > Note that the watch will still be stopped when the ObjectWatcher is > deleted. > > TBR=ben@chromium.org > BUG=616447 > > Committed: https://crrev.com/76db1513714741d8d6e6dd6e872d50f20b090fce > Cr-Commit-Position: refs/heads/master@{#407874} TBR=grt@chromium.org,ben@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=616447 Committed: https://crrev.com/00108e0c668b75d9416d50852176ce39c5454e2d Cr-Commit-Position: refs/heads/master@{#414465}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -49 lines) Patch
M base/files/file_path_watcher_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/process/kill_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/win/object_watcher.h View 3 chunks +16 lines, -25 lines 0 comments Download
M base/win/object_watcher.cc View 6 chunks +34 lines, -20 lines 0 comments Download
M chrome/common/service_process_util_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/font_fallback_win.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
fdoray
Created Revert of Remove MessageLoop::current() from base::win::ObjectWatcher.
4 years, 3 months ago (2016-08-25 16:14:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277333002/1
4 years, 3 months ago (2016-08-25 16:14:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 17:33:53 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 17:35:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00108e0c668b75d9416d50852176ce39c5454e2d
Cr-Commit-Position: refs/heads/master@{#414465}

Powered by Google App Engine
This is Rietveld 408576698