Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: runtime/bin/run_vm_tests_fuchsia.cc

Issue 2277313002: [fuchsia] Fix process launching. Update statuses. (Closed)
Patch Set: Fix comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/run_vm_tests_fuchsia.cc
diff --git a/runtime/bin/run_vm_tests_fuchsia.cc b/runtime/bin/run_vm_tests_fuchsia.cc
index 834f122d7a8332f1f0e2db49d6d547e1371b23c3..b75881d5a6e9f743e0a483becb07046b1c0e906a 100644
--- a/runtime/bin/run_vm_tests_fuchsia.cc
+++ b/runtime/bin/run_vm_tests_fuchsia.cc
@@ -31,9 +31,17 @@ const char* kSkip[] = {
"Read",
"FileLength",
"FilePosition",
- // Crash and then Hang.
+ // Crash in abort() and then hang. (MG-252)
"ArrayLengthMaxElements",
"Int8ListLengthMaxElements",
+ "ArrayNew_Overflow_Crash",
+ "SNPrint_BadArgs",
+ "IsolateReload_PendingUnqualifiedCall_InstanceToStatic",
+ "IsolateReload_PendingUnqualifiedCall_StaticToInstance",
+ "IsolateReload_PendingConstructorCall_AbstractToConcrete",
+ "IsolateReload_PendingConstructorCall_ConcreteToAbstract",
+ "IsolateReload_PendingStaticCall_DefinedToNSM",
+ "IsolateReload_PendingStaticCall_NSMToDefined",
// The profiler is turned off.
"Profiler_AllocationSampleTest",
"Profiler_ArrayAllocation",
@@ -65,28 +73,8 @@ const char* kSkip[] = {
"Dart2JSCompileAll",
// Uses too much memory.
"PrintJSON",
-};
-
-// Expected to fail/crash.
-const char* kExpectFail[] = {
- "Fail0",
- "Fail1",
- "Fail2",
- "IsolateReload_PendingUnqualifiedCall_InstanceToStatic",
- "IsolateReload_PendingUnqualifiedCall_StaticToInstance",
- "IsolateReload_PendingConstructorCall_AbstractToConcrete",
- "IsolateReload_PendingConstructorCall_ConcreteToAbstract",
- "IsolateReload_PendingStaticCall_DefinedToNSM",
- "IsolateReload_PendingStaticCall_NSMToDefined",
- "ArrayNew_Overflow_Crash",
- "AllocGeneric_Overflow",
- "CodeImmutability",
- "SNPrint_BadArgs",
-};
-
-// Bugs to fix, or things that are not yet impelemnted.
-const char* kBugs[] = {
- // Needs OS::GetCurrentThreadCPUMicros.
+ // Need OS::GetCurrentThreadCPUMicros.
+ // Skipping because they crash and hang. (MG-252)
"Timeline_Dart_TimelineGetTrace",
"Timeline_Dart_TimelineGetTraceOnlyDartEvents",
"Timeline_Dart_TimelineGetTraceWithDartEvents",
@@ -101,10 +89,21 @@ const char* kBugs[] = {
"TimelineAnalysis_ThreadBlockCount",
"TimelineRingRecorderJSONOrder",
"TimelinePauses_BeginEnd",
+};
+
+// Expected to fail/crash.
+const char* kExpectFail[] = {
+ "Fail0",
+ "Fail1",
+ "Fail2",
+ "AllocGeneric_Overflow",
+ "CodeImmutability",
+};
+
+// Bugs to fix, or things that are not yet implemented.
+const char* kBugs[] = {
// Needs NativeSymbolResolver
"Service_PersistentHandles",
- // pthread TLS destructors are not run.
- "ThreadIterator_AddFindRemove",
};
@@ -166,6 +165,8 @@ static mx_status_t lp_setup(launchpad_t** lp_out, mx_handle_t binary_vmo,
RETURN_IF_ERROR(status);
status = launchpad_elf_load(lp, binary_vmo);
RETURN_IF_ERROR(status);
+ status = launchpad_load_vdso(lp, MX_HANDLE_INVALID);
+ RETURN_IF_ERROR(status);
*lp_out = lp;
return status;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698