Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2277303002: Don't require a context for global dynamic variables (Closed)

Created:
4 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't require a context for global dynamic variables Because we don't need one. R=verwaest@chromium.org BUG= Committed: https://crrev.com/b7f796a6a4ca119d35ba5704dc01c606259afb8e Cr-Commit-Position: refs/heads/master@{#38914}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/ast/scopes.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
jochen (gone - plz use gerrit)
4 years, 3 months ago (2016-08-25 15:16:16 UTC) #1
Toon Verwaest
lgtm
4 years, 3 months ago (2016-08-25 15:25:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277303002/1
4 years, 3 months ago (2016-08-25 15:47:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 15:49:12 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 15:49:39 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7f796a6a4ca119d35ba5704dc01c606259afb8e
Cr-Commit-Position: refs/heads/master@{#38914}

Powered by Google App Engine
This is Rietveld 408576698