Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: services/ui/public/cpp/mojo_gpu_memory_buffer.h

Issue 2277293002: services/ui: Use the correct offset and stride in MojoGpuMemoryBuffer. (Closed)
Patch Set: Fix build error. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | services/ui/public/cpp/mojo_gpu_memory_buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/public/cpp/mojo_gpu_memory_buffer.h
diff --git a/services/ui/public/cpp/mojo_gpu_memory_buffer.h b/services/ui/public/cpp/mojo_gpu_memory_buffer.h
index 07e94204272bab1289d21bbce4e93eea90cb3cf2..30c0040675708afe17213399b9f8efda2e8ca78e 100644
--- a/services/ui/public/cpp/mojo_gpu_memory_buffer.h
+++ b/services/ui/public/cpp/mojo_gpu_memory_buffer.h
@@ -18,9 +18,6 @@ namespace ui {
class MojoGpuMemoryBufferImpl : public ui::GpuMemoryBufferImpl {
public:
- MojoGpuMemoryBufferImpl(const gfx::Size& size,
- gfx::BufferFormat format,
- std::unique_ptr<base::SharedMemory> shared_memory);
~MojoGpuMemoryBufferImpl() override;
static std::unique_ptr<gfx::GpuMemoryBuffer> Create(const gfx::Size& size,
@@ -46,7 +43,15 @@ class MojoGpuMemoryBufferImpl : public ui::GpuMemoryBufferImpl {
gfx::GpuMemoryBufferType GetBufferType() const override;
private:
+ MojoGpuMemoryBufferImpl(const gfx::Size& size,
sky 2016/08/25 17:00:22 Move definition to match new position.
Peng 2016/08/25 17:41:25 Done.
+ gfx::BufferFormat format,
+ std::unique_ptr<base::SharedMemory> shared_memory,
+ size_t offset,
+ int stride);
+
std::unique_ptr<base::SharedMemory> shared_memory_;
+ size_t offset_;
sky 2016/08/25 17:00:22 Make const if you can.
Peng 2016/08/25 17:41:25 Done.
+ int stride_;
DISALLOW_COPY_AND_ASSIGN(MojoGpuMemoryBufferImpl);
};
« no previous file with comments | « no previous file | services/ui/public/cpp/mojo_gpu_memory_buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698