Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: src/ast/scopes.cc

Issue 2277253003: [modules] Partial scope info support of modules (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@modules-refactor
Patch Set: This is so much fun. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/scopes.h ('k') | src/ast/variables.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/scopes.cc
diff --git a/src/ast/scopes.cc b/src/ast/scopes.cc
index f1a9a0a7b08189722969bd98f3f6737fc3fe6e6e..072ec3f2764d118a9a30050224c8f505e3d5a86b 100644
--- a/src/ast/scopes.cc
+++ b/src/ast/scopes.cc
@@ -164,6 +164,36 @@ ModuleScope::ModuleScope(DeclarationScope* script_scope,
DeclareThis(ast_value_factory);
}
+ModuleScope::ModuleScope(Isolate* isolate, Handle<ScopeInfo> scope_info,
+ AstValueFactory* avfactory)
+ : DeclarationScope(avfactory->zone(), MODULE_SCOPE, scope_info) {
+ Zone* zone = avfactory->zone();
+ ModuleInfo* module_info = scope_info->ModuleDescriptorInfo();
+
+ set_language_mode(STRICT);
+ module_descriptor_ = new (zone) ModuleDescriptor(zone);
+
+ // Deserialize special exports.
+ Handle<FixedArray> special_exports = handle(module_info->special_exports());
+ for (int i = 0, n = special_exports->length(); i < n; ++i) {
+ Handle<FixedArray> serialized_entry(
+ FixedArray::cast(special_exports->get(i)), isolate);
+ module_descriptor_->AddSpecialExport(
+ ModuleDescriptor::Entry::Deserialize(isolate, avfactory,
+ serialized_entry),
+ avfactory->zone());
+ }
+
+ // Deserialize regular exports.
+ Handle<FixedArray> regular_exports = handle(module_info->regular_exports());
+ for (int i = 0, n = regular_exports->length(); i < n; ++i) {
+ Handle<FixedArray> serialized_entry(
+ FixedArray::cast(regular_exports->get(i)), isolate);
+ module_descriptor_->AddRegularExport(ModuleDescriptor::Entry::Deserialize(
+ isolate, avfactory, serialized_entry));
+ }
+}
+
Scope::Scope(Zone* zone, ScopeType scope_type, Handle<ScopeInfo> scope_info)
: zone_(zone),
outer_scope_(nullptr),
@@ -328,6 +358,11 @@ Scope* Scope::DeserializeScopeChain(Isolate* isolate, Zone* zone,
} else {
outer_scope = new (zone) Scope(zone, BLOCK_SCOPE, scope_info);
}
+ } else if (context->IsModuleContext()) {
+ ScopeInfo* scope_info = context->closure()->shared()->scope_info();
+ DCHECK_EQ(scope_info->scope_type(), MODULE_SCOPE);
+ outer_scope = new (zone) ModuleScope(
+ isolate, Handle<ScopeInfo>(scope_info), ast_value_factory);
} else {
DCHECK(context->IsCatchContext());
String* name = context->catch_name();
@@ -428,6 +463,12 @@ void DeclarationScope::Analyze(ParseInfo* info, AnalyzeMode mode) {
scope->outer_scope()->scope_type() == SCRIPT_SCOPE ||
scope->outer_scope()->already_resolved_);
+ // For modules, we want to start variable allocation at the surrounding script
+ // scope.
+ if (scope->is_module_scope()) {
+ scope = scope->outer_scope()->AsDeclarationScope();
+ }
+
scope->AllocateVariables(info, mode);
#ifdef DEBUG
@@ -617,7 +658,8 @@ Variable* Scope::LookupInScopeInfo(const AstRawString* name) {
&init_flag, &maybe_assigned_flag);
if (index < 0 && scope_type() == MODULE_SCOPE) {
location = VariableLocation::MODULE;
- index = -1; // TODO(neis): Find module variables in scope info.
+ index = scope_info_->ModuleIndex(name_handle, &mode, &init_flag,
+ &maybe_assigned_flag);
}
if (index < 0) return nullptr; // Nowhere found.
« no previous file with comments | « src/ast/scopes.h ('k') | src/ast/variables.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698