Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: src/handles.h

Issue 2277253003: [modules] Partial scope info support of modules (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@modules-refactor
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/ast/scopes.cc ('K') | « src/ast/variables.h ('k') | src/objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/handles.h
diff --git a/src/handles.h b/src/handles.h
index a7eb31efca959bca1374f4c98c6e81d5262eb155..95fd241be1d7702a75a5a365ba03c4fb51b1547a 100644
--- a/src/handles.h
+++ b/src/handles.h
@@ -97,6 +97,11 @@ class Handle final : public HandleBase {
V8_INLINE explicit Handle(T* object) : Handle(object, object->GetIsolate()) {}
V8_INLINE Handle(T* object, Isolate* isolate) : HandleBase(object, isolate) {}
+ // XXX Can we be sure that the below is only used when T != S?
+ template <typename S>
+ V8_INLINE Handle(S* object, Isolate* isolate)
adamk 2016/08/25 16:19:43 What is this for?
neis 2016/08/26 09:52:07 I added it to save some typing but I removed it no
+ : HandleBase(T::cast(object), isolate) {}
+
// Allocate a new handle for the object, do not canonicalize.
V8_INLINE static Handle<T> New(T* object, Isolate* isolate);
« src/ast/scopes.cc ('K') | « src/ast/variables.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698