[modules] Partial scope info support of modules

src/handles.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_HANDLES_H_
 #define V8_HANDLES_H_
 
 #include "include/v8.h"
 #include "src/base/functional.h"
 #include "src/base/macros.h"
@@ skipping 79 matching lines @@
   V8_INLINE explicit Handle(T** location = nullptr)
       : HandleBase(reinterpret_cast<Object**>(location)) {
     Object* a = nullptr;
     T* b = nullptr;
     a = b;  // Fake assignment to enforce type checks.
     USE(a);
   }
   V8_INLINE explicit Handle(T* object) : Handle(object, object->GetIsolate()) {}
   V8_INLINE Handle(T* object, Isolate* isolate) : HandleBase(object, isolate) {}
 
+  // XXX Can we be sure that the below is only used when T != S?
+  template <typename S>
+  V8_INLINE Handle(S* object, Isolate* isolate)

[adamk, 2016/08/25 16:19:43]

What is this for?

[neis, 2016/08/26 09:52:07]

I added it to save some typing but I removed it now.

+      : HandleBase(T::cast(object), isolate) {}
+
   // Allocate a new handle for the object, do not canonicalize.
   V8_INLINE static Handle<T> New(T* object, Isolate* isolate);
 
   // Constructor for handling automatic up casting.
   // Ex. Handle<JSFunction> can be passed when Handle<Object> is expected.
   template <typename S>
   V8_INLINE Handle(Handle<S> handle)
       : HandleBase(handle) {
     T* a = nullptr;
     S* b = nullptr;
@@ skipping 297 matching lines @@
     next = limit = NULL;
     sealed_level = level = 0;
     canonical_scope = NULL;
   }
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_HANDLES_H_