[NTP Snippets] Safe(r) defaults for background fetching intervals

components/ntp_snippets/ntp_snippets_service.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/ntp_snippets_service.h"
 
 #include <algorithm>
 #include <iterator>
 #include <utility>
 
@@ skipping 32 matching lines @@
 using suggestions::SuggestionsService;
 
 namespace ntp_snippets {
 
 namespace {
 
 // Number of snippets requested to the server. Consider replacing sparse UMA
 // histograms with COUNTS() if this number increases beyond 50.
 const int kMaxSnippetCount = 10;
 
-// Default values for snippets fetching intervals.
-const int kDefaultFetchingIntervalWifiChargingSeconds = 30 * 60;
-const int kDefaultFetchingIntervalWifiSeconds = 2 * 60 * 60;
+// Default values for snippets fetching intervals - once per day only.
+const int kDefaultFetchingIntervalWifiChargingSeconds = 0;

[tschumann, 2016/08/25 20:28:52]

it would be really good to document this behavior -- how does this result in
once per day?
Is there any preference implemented to get it do a request over wifi?
is a value of zero deactivating the scheduling? (and what are the implications
on other fetches).

That aside: this also works when the program got kicked out of memory, right?

[Marc Treib, 2016/08/26 08:24:49]

A value of "0" disables the fetching, correct. That behavior is documented on
the NTPSnippetsScheduler interface, though it might make sense to repeat it here
:)

The "once per day" just comes from kDefaultFetchingIntervalFallbackSeconds,
which is not zero.

All these default values can be overridden via Finch.

Yes, this works even when Chrome isn't running. The OS will wake up the device,
start Chrome, and tell it to fetch.

[tschumann, 2016/08/29 12:38:41]

yes, cause when choosing these values you rely on the implementation details, so
better document.
So this means, we don't have a preference to fetch data on wifi-only? 
Now that we have the throttler in place, we can set an upper limit of one
background fetch per day. And then try fetching via wifi every hour and have the
24h fallback in case of no wifi connectivity. WDYT?

+const int kDefaultFetchingIntervalWifiSeconds = 0;
 const int kDefaultFetchingIntervalFallbackSeconds = 24 * 60 * 60;
 
 // Variation parameters than can override the default fetching intervals.
 const char kFetchingIntervalWifiChargingParamName[] =
     "fetching_interval_wifi_charging_seconds";
 const char kFetchingIntervalWifiParamName[] =
     "fetching_interval_wifi_seconds";
 const char kFetchingIntervalFallbackParamName[] =
     "fetching_interval_fallback_seconds";
 
@@ skipping 821 matching lines @@
 void NTPSnippetsService::UpdateCategoryStatus(CategoryStatus status) {
   if (status == category_status_)
     return;
 
   category_status_ = status;
   observer()->OnCategoryStatusChanged(this, provided_category_,
                                       category_status_);
 }
 
 }  // namespace ntp_snippets