Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: chrome/browser/resources/settings/site_settings/cookie_tree_node.js

Issue 2277213002: Site Settings Desktop: Fix cookie data labelling for Indexed DBs. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @typedef {{hasChildren: boolean, 6 * @typedef {{hasChildren: boolean,
7 * id: string, 7 * id: string,
8 * title: string, 8 * title: string,
9 * totalUsage: string, 9 * totalUsage: string,
10 * type: string}} 10 * type: string}}
(...skipping 29 matching lines...) Expand all
40 var CookieRemovePacket; 40 var CookieRemovePacket;
41 41
42 var categoryLabels = { 42 var categoryLabels = {
43 'app_cache': loadTimeData.getString('cookieAppCache'), 43 'app_cache': loadTimeData.getString('cookieAppCache'),
44 'cache_storage': loadTimeData.getString('cookieCacheStorage'), 44 'cache_storage': loadTimeData.getString('cookieCacheStorage'),
45 'channel_id': loadTimeData.getString('cookieChannelId'), 45 'channel_id': loadTimeData.getString('cookieChannelId'),
46 'cookie': loadTimeData.getString('cookieSingular'), 46 'cookie': loadTimeData.getString('cookieSingular'),
47 'database': loadTimeData.getString('cookieDatabaseStorage'), 47 'database': loadTimeData.getString('cookieDatabaseStorage'),
48 'file_system': loadTimeData.getString('cookieFileSystem'), 48 'file_system': loadTimeData.getString('cookieFileSystem'),
49 'flash_lso': loadTimeData.getString('cookieFlashLso'), 49 'flash_lso': loadTimeData.getString('cookieFlashLso'),
50 'indexed_db': loadTimeData.getString('cookieLocalStorage'), 50 'indexed_db': loadTimeData.getString('cookieDatabaseStorage'),
Finnur 2016/08/25 11:20:56 This change matches the old code: https://cs.chrom
dschuyler 2016/08/25 18:11:47 Acknowledged.
51 'local_storage': loadTimeData.getString('cookieLocalStorage'), 51 'local_storage': loadTimeData.getString('cookieLocalStorage'),
52 'service_worker': loadTimeData.getString('cookieServiceWorker'), 52 'service_worker': loadTimeData.getString('cookieServiceWorker'),
53 }; 53 };
54 54
55 /** 55 /**
56 * Retrieves the human friendly text to show for the type of cookie. 56 * Retrieves the human friendly text to show for the type of cookie.
57 * @param {string} dataType The datatype to look up. 57 * @param {string} dataType The datatype to look up.
58 * @param {string} totalUsage How much data is being consumed. 58 * @param {string} totalUsage How much data is being consumed.
59 * @return {string} The human-friendly description for this cookie. 59 * @return {string} The human-friendly description for this cookie.
60 */ 60 */
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 root.appendChild(content); 240 root.appendChild(content);
241 } 241 }
242 } 242 }
243 }, 243 },
244 }; 244 };
245 245
246 return { 246 return {
247 CookieTreeNode: CookieTreeNode, 247 CookieTreeNode: CookieTreeNode,
248 }; 248 };
249 }); 249 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698