Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2277213002: Site Settings Desktop: Fix cookie data labelling for Indexed DBs. (Closed)

Created:
4 years, 3 months ago by Finnur
Modified:
4 years, 3 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Site Settings Desktop: Fix cookie data labelling for Indexed DBs. BUG=640924, 614277 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/aafe66ab5cdbe2036354dd6304a1f517387bab47 Cr-Commit-Position: refs/heads/master@{#414612}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/site_settings/cookie_tree_node.js View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 13 (8 generated)
Finnur
https://codereview.chromium.org/2277213002/diff/1/chrome/browser/resources/settings/site_settings/cookie_tree_node.js File chrome/browser/resources/settings/site_settings/cookie_tree_node.js (right): https://codereview.chromium.org/2277213002/diff/1/chrome/browser/resources/settings/site_settings/cookie_tree_node.js#newcode50 chrome/browser/resources/settings/site_settings/cookie_tree_node.js:50: 'indexed_db': loadTimeData.getString('cookieDatabaseStorage'), This change matches the old code: https://cs.chromium.org/chromium/src/chrome/browser/resources/options/cookies_list.js?q=cookies_list.js&sq=package:chromium&dr&l=268
4 years, 3 months ago (2016-08-25 11:20:56 UTC) #4
dschuyler
lgtm https://codereview.chromium.org/2277213002/diff/1/chrome/browser/resources/settings/site_settings/cookie_tree_node.js File chrome/browser/resources/settings/site_settings/cookie_tree_node.js (right): https://codereview.chromium.org/2277213002/diff/1/chrome/browser/resources/settings/site_settings/cookie_tree_node.js#newcode50 chrome/browser/resources/settings/site_settings/cookie_tree_node.js:50: 'indexed_db': loadTimeData.getString('cookieDatabaseStorage'), On 2016/08/25 11:20:56, Finnur wrote: > ...
4 years, 3 months ago (2016-08-25 18:11:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277213002/1
4 years, 3 months ago (2016-08-25 22:54:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 01:19:05 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 01:21:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aafe66ab5cdbe2036354dd6304a1f517387bab47
Cr-Commit-Position: refs/heads/master@{#414612}

Powered by Google App Engine
This is Rietveld 408576698