Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 2277193002: headless: Fix browser test build failure (Closed)

Created:
4 years, 3 months ago by Sami
Modified:
4 years, 3 months ago
Reviewers:
johnme
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Fix browser test build failure The RunIfWaitingForDebugger command was made stable, breaking this test which is specifically trying to check the behavior of an experimental command. Switch to another experimental command. (The API should have remained compatible even if the command was made stable. This bug will be fixed separately.) BUG=640919 NOTRY=true Committed: https://crrev.com/beb3a83fc377236035521f5e63efc42127c8bfd4 Cr-Commit-Position: refs/heads/master@{#414385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M headless/lib/headless_devtools_client_browsertest.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Sami
4 years, 3 months ago (2016-08-25 10:44:18 UTC) #3
johnme
lgtm
4 years, 3 months ago (2016-08-25 10:45:27 UTC) #4
Sami
Thanks. Setting NOTRY=true to fix this tree closer.
4 years, 3 months ago (2016-08-25 10:46:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277193002/1
4 years, 3 months ago (2016-08-25 10:47:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 10:51:52 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 10:53:43 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/beb3a83fc377236035521f5e63efc42127c8bfd4
Cr-Commit-Position: refs/heads/master@{#414385}

Powered by Google App Engine
This is Rietveld 408576698