Issue 227713003: Further ElementsAccessor handlification (Get(), AddElementsToFixedArray() and HasElement()).

Issue 227713003: Further ElementsAccessor handlification (Get(), AddElementsToFixedArray() and HasElement()). (Closed)

Created:
6 years, 8 months ago by Igor Sheludko

Modified:
6 years, 8 months ago

Reviewers:
Toon Verwaest, Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Further ElementsAccessor handlification (Get(), AddElementsToFixedArray() and HasElement()). R=verwaest@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20581

Patch Set 2 : Addressing review notes #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+265 lines, -137 lines)			Patch
M	src/elements.h	View		2 chunks	+1 line, -7 lines	0 comments	Download
M	src/elements.cc	View	1	18 chunks	+89 lines, -109 lines	0 comments	Download
M	src/objects.h	View	1	14 chunks	+31 lines, -7 lines	0 comments	Download
M	src/objects.cc	View		2 chunks	+16 lines, -2 lines	0 comments	Download
M	src/objects-inl.h	View	1	13 chunks	+128 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

not yet :) https://codereview.chromium.org/227713003/diff/1/src/elements.cc File src/elements.cc (right): https://codereview.chromium.org/227713003/diff/1/src/elements.cc#newcode661 src/elements.cc:661: return Handle<BackingStore>::cast(backing_store)->get_as_handle(key); BackingStore::get(Handle<BackingStore> backinstore, Handle<..> key) ...

6 years, 8 months ago (2014-04-08 13:25:20 UTC) #3

Igor Sheludko

https://codereview.chromium.org/227713003/diff/1/src/elements.cc File src/elements.cc (right): https://codereview.chromium.org/227713003/diff/1/src/elements.cc#newcode661 src/elements.cc:661: return Handle<BackingStore>::cast(backing_store)->get_as_handle(key); On 2014/04/08 13:25:20, Toon Verwaest wrote: > ...

6 years, 8 months ago (2014-04-08 14:01:46 UTC) #4

Igor Sheludko

6 years, 8 months ago (2014-04-08 14:20:39 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r20581 (presubmit successful).

Expand Messages | Collapse Messages