[Offline pages] Hooking up cancel/pause/resume buttons for offline page related notifications

chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
index 691eac0ce22a5abca126abd6293d2d5a970a5d69..b68107fecffed1e238c32cac8228436821c7a327 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
@@ -129,14 +129,19 @@ public class OfflinePageDownloadBridge implements DownloadServiceDelegate, Offli
     @Override
     public void cancelDownload(String downloadGuid, boolean isOffTheRecord,
             boolean isNotificationDismissed) {
+        nativeCancelDownload(mNativeOfflinePageDownloadBridge, downloadGuid);
     }
 
     @Override
     public void pauseDownload(String downloadGuid, boolean isOffTheRecord) {
+        nativePauseDownload(mNativeOfflinePageDownloadBridge, downloadGuid);
     }
 
     @Override
     public void resumeDownload(DownloadItem item, boolean hasUserGesture) {
+        if (hasUserGesture) {

[qinmin, 2016/08/25 18:40:38]

Does offline page supports auto resumption after browser is killed?

[fgorski, 2016/08/25 18:51:34]

The requests are going to be resumed based on the background scheduler. It is
irrelevant otherwise.
We can update that presumption if this is not what you think should happen.

Unless you are saying that browser would issue a pause to all requests.
For us it makes no sense to do that, so perhaps we should add user gesture flag
to the pause as well?

[qinmin, 2016/08/25 19:02:01]

Regular download already does auto resumption. 
1. When network is disconnected and comes back, chrome auto resumes the download
if the network type allows. 
2. When chrome is killed, download will automatically resume by
gcmNetworkManager. 
3. When browser is killed and user restarts browser, download will also
automatically resume.
I don't think offline page needs separate logics on that.

+            nativeResumeDownload(mNativeOfflinePageDownloadBridge, item.getId());
+        }
     }
 
     /**
@@ -262,6 +267,9 @@ public class OfflinePageDownloadBridge implements DownloadServiceDelegate, Offli
             long nativeOfflinePageDownloadBridge, List<OfflinePageDownloadItem> items);
     native OfflinePageDownloadItem nativeGetItemByGuid(
             long nativeOfflinePageDownloadBridge, String guid);
+    native void nativeCancelDownload(long nativeOfflinePageDownloadBridge, String guid);
+    native void nativePauseDownload(long nativeOfflinePageDownloadBridge, String guid);
+    native void nativeResumeDownload(long nativeOfflinePageDownloadBridge, String guid);
     native void nativeDeleteItemByGuid(long nativeOfflinePageDownloadBridge, String guid);
     native String nativeGetOfflineUrlByGuid(long nativeOfflinePageDownloadBridge, String guid);
     native void nativeStartDownload(long nativeOfflinePageDownloadBridge, Tab tab);