Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2277103003:
Add GetCurrentNativeController to webstate. (Closed)
|
Created:
4 years, 3 months ago by justincohen Modified:
4 years, 3 months ago Reviewers:
Eugene But (OOO till 7-30) CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd GetCurrentNativeController to webstate.
BUG=
Committed: https://crrev.com/59fc7a59cf836f5af3862f6cbbb91b1c1190dac4
Cr-Commit-Position: refs/heads/master@{#414764}
Patch Set 1 #
Total comments: 8
Patch Set 2 : Address comments #Patch Set 3 : Fix method signature #
Messages
Total messages: 24 (16 generated)
justincohen@google.com changed reviewers: + eugenebut@chromium.org, justincohen@google.com
ptal
Description was changed from ========== Add GetCurrentNativeController to webstate. BUG= ========== to ========== Add GetCurrentNativeController to webstate. BUG= ==========
justincohen@chromium.org changed reviewers: - justincohen@google.com
The CQ bit was checked by justincohen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2277103003/diff/1/ios/web/public/test/native_... File ios/web/public/test/native_controller_test_util.h (right): https://codereview.chromium.org/2277103003/diff/1/ios/web/public/test/native_... ios/web/public/test/native_controller_test_util.h:5: #ifndef IOS_WEB_SHELL_PUBLIC_TEST_NATIVE_CONTROLLER_TEST_UTIL_H_ IOS_WEB_PUBLIC_TEST_NATIVE_CONTROLLER_TEST_UTIL_H_ https://codereview.chromium.org/2277103003/diff/1/ios/web/public/test/native_... ios/web/public/test/native_controller_test_util.h:13: // Returns the native controller of the current tab if the current tab is s/the current tab if the current tab is a new tab and nil otherwise./the given |web_state|. https://codereview.chromium.org/2277103003/diff/1/ios/web/public/test/native_... ios/web/public/test/native_controller_test_util.h:15: id GetCurrentNativeController(WebState* web_state); id<CRWNativeContent> ? https://codereview.chromium.org/2277103003/diff/1/ios/web/public/test/navigat... File ios/web/public/test/navigation_test_util.h (right): https://codereview.chromium.org/2277103003/diff/1/ios/web/public/test/navigat... ios/web/public/test/navigation_test_util.h:20: #endif // IOS_WEB_SHELL_PUBLIC_TEST_NAVIGATION_TEST_UTIL_H_ Please drop this change. Could you please file a bug for baxley@ to fix guards
https://codereview.chromium.org/2277103003/diff/1/ios/web/public/test/native_... File ios/web/public/test/native_controller_test_util.h (right): https://codereview.chromium.org/2277103003/diff/1/ios/web/public/test/native_... ios/web/public/test/native_controller_test_util.h:5: #ifndef IOS_WEB_SHELL_PUBLIC_TEST_NATIVE_CONTROLLER_TEST_UTIL_H_ On 2016/08/26 00:44:05, Eugene But wrote: > IOS_WEB_PUBLIC_TEST_NATIVE_CONTROLLER_TEST_UTIL_H_ Weird, why didn't presubmit catch this? https://codereview.chromium.org/2277103003/diff/1/ios/web/public/test/native_... ios/web/public/test/native_controller_test_util.h:13: // Returns the native controller of the current tab if the current tab is On 2016/08/26 00:44:05, Eugene But wrote: > s/the current tab if the current tab is a new tab and nil otherwise./the given > |web_state|. Done. https://codereview.chromium.org/2277103003/diff/1/ios/web/public/test/native_... ios/web/public/test/native_controller_test_util.h:15: id GetCurrentNativeController(WebState* web_state); On 2016/08/26 00:44:05, Eugene But wrote: > id<CRWNativeContent> ? Done. https://codereview.chromium.org/2277103003/diff/1/ios/web/public/test/navigat... File ios/web/public/test/navigation_test_util.h (right): https://codereview.chromium.org/2277103003/diff/1/ios/web/public/test/navigat... ios/web/public/test/navigation_test_util.h:20: #endif // IOS_WEB_SHELL_PUBLIC_TEST_NAVIGATION_TEST_UTIL_H_ On 2016/08/26 00:44:05, Eugene But wrote: > Please drop this change. Could you please file a bug for baxley@ to fix guards Done.
The CQ bit was checked by justincohen@chromium.org
The CQ bit was unchecked by justincohen@chromium.org
The CQ bit was checked by justincohen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eugenebut@chromium.org Link to the patchset: https://codereview.chromium.org/2277103003/#ps20001 (title: "Address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by justincohen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eugenebut@chromium.org Link to the patchset: https://codereview.chromium.org/2277103003/#ps40001 (title: "Fix method signature")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add GetCurrentNativeController to webstate. BUG= ========== to ========== Add GetCurrentNativeController to webstate. BUG= ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add GetCurrentNativeController to webstate. BUG= ========== to ========== Add GetCurrentNativeController to webstate. BUG= Committed: https://crrev.com/59fc7a59cf836f5af3862f6cbbb91b1c1190dac4 Cr-Commit-Position: refs/heads/master@{#414764} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/59fc7a59cf836f5af3862f6cbbb91b1c1190dac4 Cr-Commit-Position: refs/heads/master@{#414764} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
