Issue 2277093002: Supporting both FieldRef and InstanceRef in RetainingPathItem.parentField

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2277093002: Supporting both FieldRef and InstanceRef in RetainingPathItem.parentField (Closed)

Created:
4 years, 3 months ago by cbernaschina

Modified:
4 years, 3 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Supporting both FieldRef and InstanceRef in RetainingPathItem.parentField Fixes=https://github.com/dart-lang/sdk/issues/27146 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/942918347c16624e6d7dd7678bbb45e1e503de3a

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	runtime/observatory/lib/src/elements/retaining_path.dart	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	runtime/observatory/lib/src/models/objects/retaining_path.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/observatory/tests/observatory_ui/mocks/objects/retaining_path.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

cbernaschina

4 years, 3 months ago (2016-08-24 23:57:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
942918347c16624e6d7dd7678bbb45e1e503de3a (presubmit successful).