Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2277083002: Fix a crash in AVDA when dereferencing a null task runner (Closed)

Created:
4 years, 4 months ago by watk
Modified:
4 years, 3 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a crash in AVDA when dereferencing a null task runner Previously AVDAManager::StopThread() made the incorrect assumption that the construction thread was running before using its task runner. Now we only use the task runner when the the thread is running. BUG=640806 TEST=run the webrtc.peerconnection benchmark Committed: https://crrev.com/970f2b01f45ed574d12ffe9652191c7cf2c2f5fd Cr-Commit-Position: refs/heads/master@{#414503}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/gpu/android_video_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
watk
4 years, 4 months ago (2016-08-24 23:42:43 UTC) #4
DaleCurtis
lgtm
4 years, 4 months ago (2016-08-24 23:51:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277083002/1
4 years, 4 months ago (2016-08-24 23:53:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/129465)
4 years, 4 months ago (2016-08-25 01:52:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277083002/1
4 years, 3 months ago (2016-08-25 17:46:12 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 19:18:12 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 19:21:53 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/970f2b01f45ed574d12ffe9652191c7cf2c2f5fd
Cr-Commit-Position: refs/heads/master@{#414503}

Powered by Google App Engine
This is Rietveld 408576698