Add drawRegion() API to SkCanvas

src/core/SkDevice.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkColorFilter.h"
 #include "SkDevice.h"
 #include "SkDraw.h"
@@ skipping 54 matching lines @@
             break;
         case kNever_TileUsage:
             if (!preserveLCDText) {
                 geo = kUnknown_SkPixelGeometry;
             }
             break;
     }
     return geo;
 }
 
+void SkBaseDevice::drawRegion(const SkDraw& draw, const SkRegion& region, const SkPaint& paint) {
+    bool complexMatrix = !draw.fMatrix->isScaleTranslate();
+    bool complexPaint = paint.isAntiAlias() || paint.getImageFilter() || paint.getMaskFilter();
+    if (complexMatrix && complexPaint) {

[msarett, 2016/08/25 13:02:32]

Hwui also checks that the paint must be kFill_Style before choosing "simple
rects".  Is this something that we also need to worry about?

[bsalomon, 2016/08/25 13:58:20]

To me a clear definition of drawRegion(region, paint) is that it draws the same
as drawPath(region.getBoundaryPath(), paint).

If we accept that definition then a path effect or non-fill style would also
throw us out of the rect-at-a-time implementation.

[msarett, 2016/08/25 15:07:35]

Agreed.

New checks should catch everything I think:
(1) Default to path if non-translate.
(2) Default to path if non-fill, mask filter, or path effect.
(3) Default to path if anti-alias AND we'll actually have non-integer pixels.

We'll miss the fast path on the case where we have a scale matrix with integer
scales - I think that's ok.

Image filters should work fine on the fast path.

+        SkPath path;
+        region.getBoundaryPath(&path);
+        return this->drawPath(draw, path, paint, nullptr, false);
+    }
+
+    SkRegion::Iterator it(region);
+    while (!it.done()) {
+        this->drawRect(draw, SkRect::Make(it.rect()), paint);
+        it.next();
+    }
+}
+
 void SkBaseDevice::drawArc(const SkDraw& draw, const SkRect& oval, SkScalar startAngle,
                            SkScalar sweepAngle, bool useCenter, const SkPaint& paint) {
     SkASSERT(SkScalarAbs(sweepAngle) >= 0.f && SkScalarAbs(sweepAngle) < 360.f);
     SkPath path;
     if (useCenter) {
         path.moveTo(oval.centerX(), oval.centerY());
     }
     path.arcTo(oval, startAngle, sweepAngle, !useCenter);
     if (useCenter) {
         path.close();
@@ skipping 465 matching lines @@
 
     // Also log filter quality independent scale factor.
     SK_HISTOGRAM_ENUMERATION("DrawScaleFactor.AnyFilterQuality", scaleFactor,
                              kLast_ScaleFactor + 1);
 
     // Also log an overall histogram of filter quality.
     SK_HISTOGRAM_ENUMERATION("FilterQuality", filterQuality, kLast_SkFilterQuality + 1);
 #endif
 }